fix: preserve observation-major Harmony output - #487
Open
mvanhorn wants to merge 1 commit into
Open
Conversation
Member
|
Thanks! I think the tests can be removed for such a small change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
_harmonyinsnapatac2/preprocessing/_harmony.pyto normalizeZ_corragainst the input observation count: keep an observation-major result unchanged and transpose a component-major result for compatibility with olderharmonypyreleases.snap.pp.harmonycurrently transposesharmonypy'sZ_corrresult unconditionally before its public wrapper stores the matrix in.obsm.Verify observation-major
Z_corris returned unchanged and can be written byharmony(..., inplace=True)to an AnnData.obsmentry with shape(n_obs, n_components); Verify legacy component-majorZ_corris transposed to the same observation-major shape, including theinplace=Falsereturn path.Closes #465