Skip to content

ci: build example apps to catch dependency and tailwind breakage - #3480

Open
jordanl17 wants to merge 1 commit into
mainfrom
ci/build-apps
Open

ci: build example apps to catch dependency and tailwind breakage#3480
jordanl17 wants to merge 1 commit into
mainfrom
ci/build-apps

Conversation

@jordanl17

Copy link
Copy Markdown
Member

What

Adds a build-apps CI job that builds the example apps, so build breakages (undeclared dependencies, framework/major dependency bumps, Tailwind v4-style PostCSS breakage) are caught at PR time instead of only surfacing on a Vercel cache miss.

Today CI runs pnpm build --filter=!./apps/* (apps excluded) and the turbo remote cache (shared by CI and Vercel) replays stale package successes, so broken app builds go unnoticed until Vercel misses cache. This job closes that gap. It passes --force to bypass the turbo cache so latent breakage is not masked.

How

  • studio: built fully via turbo (no build-time Sanity fetch, so it is deterministic).
  • next / live-next / page-builder-demo: built with next build --experimental-build-mode=compile. This runs the Turbopack compile + PostCSS/Tailwind stage (where undeclared-dep and dependency/Tailwind breakage actually fails) without collecting page data or prerendering.

The job mirrors the existing build job setup (checkout, pnpm/action-setup, setup-node with pnpm cache, TURBO_TOKEN/TURBO_TEAM, pnpm install --ignore-scripts).

Limitation / tradeoff

There is no SANITY_API_READ_TOKEN secret in the repo. The apps read that token at module load and throw without it, and the Pages Router pages (getStaticProps) and App Router dynamic routes fetch live Sanity data at build time - a full next build returns 401 Unauthorized and fails collecting page data. A full app build therefore cannot pass deterministically in CI without that secret and live data.

Compile mode is the largest deterministically-green check that still catches the target breakage class. Verified locally that it catches both a used undeclared import (Module not found) and a bad Tailwind utility (Cannot apply unknown utility class), while a clean tree exits 0. It does not catch breakage that only manifests during prerender/data-collection; covering that would require provisioning a read token and stable build-time data.

Stacked on #(fix/next-build-time-sanity-fetch) so the diff stays narrow and CI runs against the dependency/Tailwind fixes on that branch.

@changeset-bot

changeset-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: df63bc4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Jun 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
live-visual-editing-next Ready Ready Preview, Comment Jun 18, 2026 4:18pm
visual-editing-next Ready Ready Preview, Comment Jun 18, 2026 4:18pm
visual-editing-page-builder-demo Ready Ready Preview, Comment Jun 18, 2026 4:18pm
visual-editing-storybook Ready Ready Preview, Comment Jun 18, 2026 4:18pm
visual-editing-studio Ready Ready Preview, Comment Jun 18, 2026 4:18pm
5 Skipped Deployments
Project Deployment Actions Updated (UTC)
visual-editing-astro Ignored Ignored Jun 18, 2026 4:18pm
visual-editing-next-with-i18n Ignored Ignored Jun 18, 2026 4:18pm
visual-editing-nuxt Ignored Ignored Jun 18, 2026 4:18pm
visual-editing-remix Ignored Ignored Jun 18, 2026 4:18pm
visual-editing-svelte Ignored Ignored Jun 18, 2026 4:18pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants