Skip to content

fix(deps): complete tailwindcss v4 migration and add missing @sanity/icons dependency - #3479

Merged
jordanl17 merged 3 commits into
mainfrom
fix/next-build-time-sanity-fetch
Jun 18, 2026
Merged

fix(deps): complete tailwindcss v4 migration and add missing @sanity/icons dependency#3479
jordanl17 merged 3 commits into
mainfrom
fix/next-build-time-sanity-fetch

Conversation

@jordanl17

@jordanl17 jordanl17 commented Jun 17, 2026

Copy link
Copy Markdown
Member

What

Fixes a cluster of latent Vercel build failures in the example apps and storybook, all caused by recent dependency changes that CI never caught (CI builds --filter=!./apps/*, so only Vercel builds the apps; the turbo remote cache also masked broken package builds until a cache miss).

  • Tailwind v4 migration across every tailwind3-catalog consumer (apps/next, apps/live-next, apps/page-builder-demo, packages/visual-editing):
    • PostCSS configs switched from tailwindcss: {} to @tailwindcss/postcss.
    • CSS entrypoints switched from @tailwind base/components/utilities to @import 'tailwindcss' plus a @config directive that keeps each existing tailwind.config (preserving the typography plugin and @sanity/demo theme).
    • autoprefixer dropped from the PostCSS configs/deps (v4 handles prefixing via Lightning CSS).
  • Declare missing-but-imported dependencies (previously resolved only via pnpm hoisting / a stale turbo cache):
    • @sanity/icons added to apps/next, apps/page-builder-demo, and apps/studio.
    • react added to @repo/sanity-schema.

Why

Commit 4b25bc0a (#3465) bumped the tailwind3 catalog to tailwindcss@^4.3.1 but migrated none of the consumers, so a fresh Vercel build threw on the v3 PostCSS plugin syntax. Separately, several packages/apps imported @sanity/icons / react without declaring them - fine under hoisting and while the turbo cache replayed old successes, but broken on any real rebuild. These only ever surfaced on Vercel.

Testing

  • pnpm --filter @sanity/visual-editing build-storybook - passes.
  • pnpm --filter @repo/sanity-schema build - passes.
  • apps/next and apps/page-builder-demo next build - both compile successfully; the tailwind PostCSS and @sanity/icons errors are gone.
  • pnpm build --filter='!./apps/*' - all packages build.
  • Vercel preview deploys on this PR (visual-editing-next, visual-editing-storybook, visual-editing-page-builder-demo, visual-editing-studio confirmed green).

Follow-up (not in this PR)

The tailwind3 catalog now pins v4, so its name is misleading - a rename to tailwind/tailwind4 would be a small, separate cleanup.

@vercel

vercel Bot commented Jun 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
visual-editing-storybook Ready Ready Preview, Comment Jun 17, 2026 11:29pm
visual-editing-studio Ready Ready Preview Jun 17, 2026 11:29pm
8 Skipped Deployments
Project Deployment Actions Updated (UTC)
visual-editing-astro Ignored Ignored Jun 17, 2026 11:29pm
visual-editing-next-with-i18n Ignored Ignored Jun 17, 2026 11:29pm
visual-editing-nuxt Ignored Ignored Jun 17, 2026 11:29pm
visual-editing-remix Ignored Ignored Jun 17, 2026 11:29pm
visual-editing-svelte Ignored Ignored Jun 17, 2026 11:29pm
live-visual-editing-next Skipped Skipped Jun 17, 2026 11:29pm
visual-editing-next Skipped Skipped Jun 17, 2026 11:29pm
visual-editing-page-builder-demo Skipped Skipped Jun 17, 2026 11:29pm

Request Review

@changeset-bot

changeset-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d5302ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jordanl17
jordanl17 force-pushed the fix/next-build-time-sanity-fetch branch from 96d1958 to 03a38b3 Compare June 17, 2026 23:16
@jordanl17 jordanl17 changed the title fix(next): convert pages-router build-time fetches to getServerSideProps fix(deps): complete tailwindcss v4 migration and add missing @sanity/icons dependency Jun 17, 2026
@socket-security

socket-security Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​@​tailwindcss/​postcss@​4.3.110010010098100

View full report

@vercel
vercel Bot temporarily deployed to Preview – live-visual-editing-next June 17, 2026 23:28 Inactive
@vercel
vercel Bot temporarily deployed to Preview – visual-editing-page-builder-demo June 17, 2026 23:28 Inactive
@vercel
vercel Bot temporarily deployed to Preview – visual-editing-next June 17, 2026 23:28 Inactive
@jordanl17
jordanl17 requested a review from stipsan June 17, 2026 23:45
@jordanl17
jordanl17 marked this pull request as ready for review June 17, 2026 23:45
@jordanl17
jordanl17 enabled auto-merge (squash) June 17, 2026 23:50
@jordanl17

Copy link
Copy Markdown
Member Author

Also note that I'm planning on adding a CI build step of these studios to hopefully catch these sorts of regressions in the future: #3480

@jordanl17
jordanl17 merged commit e7d2cd7 into main Jun 18, 2026
18 checks passed
@jordanl17
jordanl17 deleted the fix/next-build-time-sanity-fetch branch June 18, 2026 16:07
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants