fix(deps): complete tailwindcss v4 migration and add missing @sanity/icons dependency - #3479
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
8 Skipped Deployments
|
|
96d1958 to
03a38b3
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Also note that I'm planning on adding a CI build step of these studios to hopefully catch these sorts of regressions in the future: #3480 |
What
Fixes a cluster of latent Vercel build failures in the example apps and storybook, all caused by recent dependency changes that CI never caught (CI builds
--filter=!./apps/*, so only Vercel builds the apps; the turbo remote cache also masked broken package builds until a cache miss).tailwind3-catalog consumer (apps/next,apps/live-next,apps/page-builder-demo,packages/visual-editing):tailwindcss: {}to@tailwindcss/postcss.@tailwind base/components/utilitiesto@import 'tailwindcss'plus a@configdirective that keeps each existingtailwind.config(preserving the typography plugin and@sanity/demotheme).autoprefixerdropped from the PostCSS configs/deps (v4 handles prefixing via Lightning CSS).@sanity/iconsadded toapps/next,apps/page-builder-demo, andapps/studio.reactadded to@repo/sanity-schema.Why
Commit
4b25bc0a(#3465) bumped thetailwind3catalog totailwindcss@^4.3.1but migrated none of the consumers, so a fresh Vercel build threw on the v3 PostCSS plugin syntax. Separately, several packages/apps imported@sanity/icons/reactwithout declaring them - fine under hoisting and while the turbo cache replayed old successes, but broken on any real rebuild. These only ever surfaced on Vercel.Testing
pnpm --filter @sanity/visual-editing build-storybook- passes.pnpm --filter @repo/sanity-schema build- passes.apps/nextandapps/page-builder-demonext build- both compile successfully; the tailwind PostCSS and@sanity/iconserrors are gone.pnpm build --filter='!./apps/*'- all packages build.visual-editing-next,visual-editing-storybook,visual-editing-page-builder-demo,visual-editing-studioconfirmed green).Follow-up (not in this PR)
The
tailwind3catalog now pins v4, so its name is misleading - a rename totailwind/tailwind4would be a small, separate cleanup.