Skip to content

Upgrade rails from 8.0.4.1 to 8.0.5, minitest from 5.27.0 to 6.0.2, connection_pool from 2.5.5 to 3.0.2#6364

Merged
colby-swandale merged 3 commits intorubygems:masterfrom
larouxn:rails_8.0.5_minitest_6
Mar 30, 2026
Merged

Upgrade rails from 8.0.4.1 to 8.0.5, minitest from 5.27.0 to 6.0.2, connection_pool from 2.5.5 to 3.0.2#6364
colby-swandale merged 3 commits intorubygems:masterfrom
larouxn:rails_8.0.5_minitest_6

Conversation

@larouxn
Copy link
Copy Markdown
Contributor

@larouxn larouxn commented Mar 24, 2026

Description

Proposing we upgrade Rails to latest patch release, from 8.0.4.1 to 8.0.5. While doing so, as the Rails upgrade unblocks the following, let's also upgrade from Minitest 5.27.0 to 6.0.2 and ConnectionPool 2.5.5 to 3.0.2.

Release notes

Related to #6335 (Rails 8.1 bump)
Potentially related to #6302 (Dalli bump)
Supersedes #6301 (Minitest bump)
Supersedes #6165 (ConnectionPool bump)

How?

  1. Bump Gemfile entries
  2. bundle update calls
  3. [Minitest 6] Fix one test that improperly asserted nil instead of an actual token
CompromisedPasswordsControllerTest#test_: on GET to show with valid session should not update user confirmation_token on page visit.  [test/functional/compromised_passwords_controller_test.rb:39]:
Use assert_nil if expecting nil.
  1. [Minitest 6] Made two MFA methods public as assert_predicate no longer works with private methods

Am open to opinions on all of this especially points 3 and 4, mainly 4. (CI test failure logs)

Testing

Overall this is mostly a upgrade/bug fix kind of PR we've been waiting to do. The biggest change is Minitest 6 which considering it's a testing gem means we're likely fine so long as CI is happy.

@larouxn larouxn changed the title Upgrade from Rails 8.0.4.1 to 8.0.5 and Minitest from 5.27.0 to 6.0.2 Upgrade Rails from 8.0.4.1 to 8.0.5 and Minitest from 5.27.0 to 6.0.2 Mar 24, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.48%. Comparing base (dd8f309) to head (6bb31b9).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6364      +/-   ##
==========================================
- Coverage   97.07%   94.48%   -2.60%     
==========================================
  Files         489      489              
  Lines       10373    10432      +59     
==========================================
- Hits        10070     9857     -213     
- Misses        303      575     +272     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@larouxn larouxn marked this pull request as draft March 24, 2026 21:12
@larouxn larouxn force-pushed the rails_8.0.5_minitest_6 branch from a3e9945 to 710d948 Compare March 24, 2026 21:23
@larouxn larouxn changed the title Upgrade Rails from 8.0.4.1 to 8.0.5 and Minitest from 5.27.0 to 6.0.2 Upgrade rails from 8.0.4.1 to 8.0.5, minitest from 5.27.0 to 6.0.2, connection_pool from 2.5.5 to 3.0.2 Mar 24, 2026
Release notes
- https://github.com/minitest/minitest/blob/a2d0904767e058c962dda89e37192097cce14de2/History.rdoc#600--2025-12-17

Additional changes
- one test that improperly asserted nil instead of an actual token
- moved two methods from private to public as assert_predicate no longer works with private methods
@larouxn larouxn force-pushed the rails_8.0.5_minitest_6 branch from 710d948 to 1d786c0 Compare March 24, 2026 23:00
@larouxn larouxn marked this pull request as ready for review March 24, 2026 23:10
@larouxn larouxn force-pushed the rails_8.0.5_minitest_6 branch from 1d786c0 to 6bb31b9 Compare March 24, 2026 23:16
Comment thread app/models/concerns/user_multifactor_methods.rb
Comment thread test/functional/compromised_passwords_controller_test.rb
@colby-swandale colby-swandale merged commit 58b23ae into rubygems:master Mar 30, 2026
21 of 22 checks passed
@github-project-automation github-project-automation Bot moved this from Ready to Merged in RubyGems.org Pull Requests Mar 30, 2026
@larouxn larouxn deleted the rails_8.0.5_minitest_6 branch March 30, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants