Upgrade rails from 8.0.4.1 to 8.0.5, minitest from 5.27.0 to 6.0.2, connection_pool from 2.5.5 to 3.0.2#6364
Merged
colby-swandale merged 3 commits intorubygems:masterfrom Mar 30, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6364 +/- ##
==========================================
- Coverage 97.07% 94.48% -2.60%
==========================================
Files 489 489
Lines 10373 10432 +59
==========================================
- Hits 10070 9857 -213
- Misses 303 575 +272 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a3e9945 to
710d948
Compare
Release notes - https://github.com/minitest/minitest/blob/a2d0904767e058c962dda89e37192097cce14de2/History.rdoc#600--2025-12-17 Additional changes - one test that improperly asserted nil instead of an actual token - moved two methods from private to public as assert_predicate no longer works with private methods
710d948 to
1d786c0
Compare
1d786c0 to
6bb31b9
Compare
larouxn
commented
Mar 24, 2026
colby-swandale
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Proposing we upgrade Rails to latest patch release, from 8.0.4.1 to 8.0.5. While doing so, as the Rails upgrade unblocks the following, let's also upgrade from Minitest 5.27.0 to 6.0.2 and ConnectionPool 2.5.5 to 3.0.2.
Release notes
Related to #6335 (Rails 8.1 bump)
Potentially related to #6302 (Dalli bump)
Supersedes #6301 (Minitest bump)
Supersedes #6165 (ConnectionPool bump)
How?
bundle updatecallsnilinstead of an actual tokenassert_predicateno longer works with private methodsAm open to opinions on all of this especially points 3 and 4, mainly 4. (CI test failure logs)
Testing
Overall this is mostly a upgrade/bug fix kind of PR we've been waiting to do. The biggest change is Minitest 6 which considering it's a testing gem means we're likely fine so long as CI is happy.