Skip to content

Fix epub issue #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uyscuti-wiki merged 3 commits into from
Aug 5, 2026
Merged

Fix epub issue #517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40b5f2d
Remove d-none class
azizullahsaeidi Jul 29, 2026
ddd09ce
Add null checks for buttons, progress bar, and status elements
azizullahsaeidi Jul 29, 2026
571a4fd
Update the code
azizullahsaeidi Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions resources/assets/js/epub.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,21 +140,33 @@ class EPUBViewer {
}

updateControls() {
document.getElementById('prevBtn').disabled = this.currentPage === 0;
document.getElementById('nextBtn').disabled = this.currentPage >= this.totalPages - 1;
const prevBtn = document.getElementById('prevBtn');
const nextBtn = document.getElementById('nextBtn');

if (prevBtn){
prevBtn.disabled = this.currentPage === 0;
}
if (nextBtn) {
nextBtn.disabled = this.currentPage >= this.totalPages - 1;
}
}

updateProgress() {
if (this.totalPages > 0) {
const progress = ((this.currentPage + 1) / this.totalPages) * 100;
document.getElementById('progressBar').style.width = progress + '%';
const progressBar = document.getElementById('progressBar');
if (progressBar) {
progressBar.style.width = progress + '%';
}
}
}

updateStatus() {
if (this.totalPages > 0) {
document.getElementById('epubStatus').textContent =
` ${this.currentPage + 1} / ${this.totalPages}`;
const epubStatus = document.getElementById('epubStatus');
if (epubStatus) {
epubStatus.textContent = ` ${this.currentPage + 1} / ${this.totalPages}`;
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion resources/views/resources/resources_view.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
@lang('Your browser does not support audio, please download the file.')
</audio>
@elseif($ePub)
<div class="container-fluid p-2 d-none" id="epubViewer">
<div class="container-fluid p-2" id="epubViewer">
<div class="text-center mb-4">
<h1 class="display-4 fw-light mb-2" id="epubTitle">@lang('Loading, please wait')</h1>
<p class="fs-5 text-muted" id="epubAuthor">@lang('Author')</p>
Expand Down
Loading