Fix epub issue - #517
Merged
Merged
Conversation
uyscuti-wiki
approved these changes
Aug 5, 2026
uyscuti-wiki
left a comment
uyscuti-wiki
left a comment
Collaborator
There was a problem hiding this comment.
Looks great, Aziz. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR belongs to this Jira ticket
What this PR does
Fixes the bug where the ePUB viewer wasn't initializing and displaying.
Why it was happening
The JS script was crashing on load because it was trying to update elements (like buttons and progress bars) that didn't actually exist with those IDs in the Blade file yet. On top of that, the container had the
d-noneclass on it, keeping it completely hidden.Changes made
d-noneclass from the main viewer wrapper and added the missing element IDs (prevBtn,nextBtn,progressBar, andepubStatus) so the JS can actually find them.ifchecks inside the control, progress, and status update functions so the script won't hard-crash if an element is missing or takes a second to load.Please run this command