Remove unused abind dependency#171
Merged
Merged
Conversation
abind is in Imports with an @importFrom (and NAMESPACE entry) but abind() is never called anywhere in the package. Remove it. dplyr (Imports) and the removal of reshape2 are already present on main, so this completes the remaining dependency-declaration cleanup. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unused
abinddependency:abindfromImports(DESCRIPTION).@importFrom abind abind(R/ssdtools-package.R) and the matchingNAMESPACEline.abind()is never called anywhere in the package — only the import existed.Context
This is the remaining piece of a dependency-declaration cleanup. The other items (moving
dplyrtoImports, removingreshape2) are already present onpoissonconsulting/main, so only theabindremoval was outstanding here. (Originally raised against bcgov as bcgov#476 / bcgov#477; retargeted to this fork.)Test plan
R CMD check(not run here)