Fix dependency declarations (dplyr to Imports; drop unused abind, reshape2)#477
Closed
joethorley wants to merge 1 commit into
Closed
Fix dependency declarations (dplyr to Imports; drop unused abind, reshape2)#477joethorley wants to merge 1 commit into
joethorley wants to merge 1 commit into
Conversation
- Move dplyr from Suggests to Imports: it is used unconditionally via dplyr:: in 13 files in R/, so it must be a hard dependency. - Remove abind from Imports and drop its @importFrom (and the matching NAMESPACE entry); abind() is never called. - Remove unused reshape2 from Suggests. plyr is retained (used by plyr::summarise() in R/ggproto.R). Closes #476 Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
1 task
Collaborator
Author
|
Superseded by poissonconsulting#171, which targets Note: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #476.
Summary
dplyr:Suggests→Imports.dplyr::is called unconditionally in 13 files inR/(hc.R,hcp-ma.R,gof.R,tidy.R,glance.R,plot-cdf.R, ...). It must be a hard dependency; otherwiseR CMD checkflags it and those functions fail at runtime withoutdplyrinstalled.abindfromImportsand drop the@importFrom abind abind(and the matchingNAMESPACEline).abind()is never called.reshape2fromSuggests(not referenced inR/,tests/, orvignettes/; also superseded).plyris intentionally retained — it is genuinely used byplyr::summarise()inR/ggproto.R.NAMESPACEwas edited by hand to match (one removed line); it is otherwise whatdevtools::document()would produce.NEWS.mdis fledge-managed so left untouched.Test plan
R CMD check/devtools::check()(not run here)Opened as a draft pending maintainer review.