-
Notifications
You must be signed in to change notification settings - Fork 12
chore(ci): update sha for podman-install action #594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -58,6 +58,9 @@ jobs: | |
| name: ${{ matrix.windows-version }} - ${{ matrix.rootful == '0' && 'rootless' || 'rootful' }} ${{ matrix.user-networking == '1' && '- user mode networking enabled' || '' }} | ||
| timeout-minutes: 180 | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no need for this. |
||
| contents: read | ||
| actions: read | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
|
|
@@ -76,7 +79,7 @@ jobs: | |
| steps: | ||
| - name: Fetch latest Podman version | ||
| id: fetch-podman | ||
| uses: redhat-actions/podman-install/.github/actions/fetch-latest-podman-version-windows@aea6ff44f2a4a82da13d22061ce73443a125925d | ||
| uses: redhat-actions/podman-install/.github/actions/fetch-latest-podman-version-windows@60b05ab5b050c9f8ec8dff7e0377f8bf36c39207 | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| with: | ||
| version_input: ${{ github.event.inputs.podman_version || 'latest' }} | ||
| file_type: 'msi' | ||
|
|
@@ -94,6 +97,7 @@ jobs: | |
| '{for (i=1; i<=NF; i++) {split($i, kv, "="); print kv[1]"="kv[2]}}' >> $GITHUB_ENV | ||
| # Set podman configuration variables from fetched version | ||
| echo "PODMAN_URL=${{ steps.fetch-podman.outputs.download_url }}" >> $GITHUB_ENV | ||
| echo "PODMAN_LOCAL_INSTALLER=${{ steps.fetch-podman.outputs.local_installer_path }}" >> $GITHUB_ENV | ||
| echo "${{ github.event.inputs.podman_machine_options || env.DEFAULT_PODMAN_MACHINE_OPTIONS }}" | awk -F ',' \ | ||
| '{for (i=1; i<=NF; i++) {split($i, kv, "="); print "PODMAN_"kv[1]"="kv[2]}}' >> $GITHUB_ENV | ||
| echo "PODMAN_PROVIDER=${{ github.event.inputs.podman_provider || env.DEFAULT_PODMAN_PROVIDER }}" >> $GITHUB_ENV | ||
|
|
@@ -142,6 +146,8 @@ jobs: | |
| with: | ||
| podman-image-tag: ${{ env.PDE2E_PODMAN }} | ||
| podman-download-url: ${{ env.PODMAN_URL }} | ||
| podman-local-installer: ${{ env.PODMAN_LOCAL_INSTALLER }} | ||
| podman-provider: ${{ env.PODMAN_PROVIDER }} | ||
|
|
||
| - name: Run Podman Desktop Playwright E2E tests | ||
| uses: podman-desktop/e2e/.github/actions/run-playwright-test@main | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,7 +26,7 @@ on: | |
| required: true | ||
| podman_options: | ||
| default: 'PODMAN_VERSION=latest,INIT=1,START=1,ROOTFUL=1,NETWORKING=0,PROVIDER=wsl' | ||
| description: 'Podman configuration options with provider choice. For PODMAN_VERSION use "latest" or a version like "v5.6.2"; for PROVIDER use "wsl" or "hyperv" options.' | ||
| description: 'Podman configuration options with provider choice. For PODMAN_VERSION use "latest", "nightly", or a version like "v5.6.2"; for PROVIDER use "wsl" or "hyperv" options.' | ||
| type: string | ||
| required: true | ||
| env_vars: | ||
|
|
@@ -55,6 +55,9 @@ jobs: | |
| name: ${{ matrix.windows-version }} - Debug | ||
| timeout-minutes: 180 | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why is it needed? |
||
| contents: read | ||
| actions: read | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
|
|
@@ -73,7 +76,7 @@ jobs: | |
|
|
||
| - name: Fetch Podman version | ||
| id: fetch-podman | ||
| uses: redhat-actions/podman-install/.github/actions/fetch-latest-podman-version-windows@aea6ff44f2a4a82da13d22061ce73443a125925d | ||
| uses: redhat-actions/podman-install/.github/actions/fetch-latest-podman-version-windows@60b05ab5b050c9f8ec8dff7e0377f8bf36c39207 | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| with: | ||
| version_input: ${{ steps.extract-version.outputs.podman_version }} | ||
| file_type: 'msi' | ||
|
|
@@ -88,6 +91,7 @@ jobs: | |
| echo "${PODMAN_OPTS}" | awk -F ',' \ | ||
| '{for (i=1; i<=NF; i++) {split($i, kv, "="); if(kv[1] != "PODMAN_VERSION") print "PODMAN_"kv[1]"="kv[2]}}' >> $GITHUB_ENV | ||
| echo "PODMAN_REMOTE_URL=${{ steps.fetch-podman.outputs.download_url }}" >> $GITHUB_ENV | ||
| echo "PODMAN_LOCAL_INSTALLER=${{ steps.fetch-podman.outputs.local_installer_path }}" >> $GITHUB_ENV | ||
| echo "${{ github.event.inputs.ext_repo_options }}" | awk -F ',' \ | ||
| '{for (i=1; i<=NF; i++) {split($i, kv, "="); print "EXT_"kv[1]"="kv[2]}}' >> $GITHUB_ENV | ||
| echo "${{ github.event.inputs.pd_repo_options }}" | awk -F ',' \ | ||
|
|
@@ -135,6 +139,8 @@ jobs: | |
| with: | ||
| podman-image-tag: ${{ env.PDE2E_PODMAN }} | ||
| podman-download-url: ${{ env.PODMAN_REMOTE_URL }} | ||
| podman-local-installer: ${{ env.PODMAN_LOCAL_INSTALLER }} | ||
| podman-provider: ${{ env.PODMAN_PROVIDER }} | ||
|
|
||
| - name: Run Podman Desktop Playwright E2E tests | ||
| uses: podman-desktop/e2e/.github/actions/run-playwright-test@main | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -63,6 +63,9 @@ jobs: | |
| name: ${{ matrix.windows-version }} - ${{ matrix.windows-featurepack }} | ||
| timeout-minutes: 90 | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same. |
||
| contents: read | ||
| actions: read | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
|
|
@@ -98,7 +101,7 @@ jobs: | |
|
|
||
| - name: Fetch latest Podman version | ||
| id: fetch-podman | ||
| uses: redhat-actions/podman-install/.github/actions/fetch-latest-podman-version-windows@aea6ff44f2a4a82da13d22061ce73443a125925d | ||
| uses: redhat-actions/podman-install/.github/actions/fetch-latest-podman-version-windows@60b05ab5b050c9f8ec8dff7e0377f8bf36c39207 | ||
| with: | ||
| version_input: ${{ github.event.inputs.podman_version || 'latest' }} | ||
| file_type: 'msi' | ||
|
|
@@ -116,6 +119,7 @@ jobs: | |
| echo "NPM_TARGET=${{ github.event.inputs.npm_target || env.DEFAULT_NPM_TARGET }}" >> $GITHUB_ENV | ||
| echo "PODMAN_PROVIDER=${{ github.event.inputs.podman_provider || env.DEFAULT_PODMAN_PROVIDER }}" >> $GITHUB_ENV | ||
| echo "PODMAN_URL=${{ steps.fetch-podman.outputs.download_url }}" >> $GITHUB_ENV | ||
| echo "PODMAN_LOCAL_INSTALLER=${{ steps.fetch-podman.outputs.local_installer_path }}" >> $GITHUB_ENV | ||
| echo "PD_URL=${{ github.event.inputs.podman_desktop_url || env.DEFAULT_PD_URL }}" >> $GITHUB_ENV | ||
| echo "ENV_VARS=${{ github.event.inputs.env_vars || env.DEFAULT_ENV_VARS }}" >> $GITHUB_ENV | ||
| echo "${{ github.event.inputs.podman_options || env.DEFAULT_PODMAN_OPTIONS }}" | awk -F ',' \ | ||
|
|
@@ -159,6 +163,8 @@ jobs: | |
| with: | ||
| podman-image-tag: ${{ env.PDE2E_PODMAN }} | ||
| podman-download-url: ${{ env.PODMAN_URL }} | ||
| podman-local-installer: ${{ env.PODMAN_LOCAL_INSTALLER }} | ||
| podman-provider: ${{ env.PODMAN_PROVIDER }} | ||
|
|
||
| - name: Run Podman Desktop Playwright E2E tests | ||
| uses: podman-desktop/e2e/.github/actions/run-playwright-test@main | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why cannot we just pass an url to the nightly so that the action/image can pull the installer and use it?