chore(ci): update sha for podman-install action#594
Draft
danivilla9 wants to merge 3 commits into
Draft
Conversation
Signed-off-by: Daniel Villanueva <[email protected]>
📝 WalkthroughWalkthroughThe Podman nightly action now supports local MSI installation with URL fallback. Eight Windows E2E workflows pass fetched installer paths and provider settings, update action pins, add read permissions, and document nightly version selection. ChangesWindows Podman local installation
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant WindowsWorkflow
participant FetchPodman
participant DownloadPodmanNightly
participant WindowsHost
WindowsWorkflow->>FetchPodman: fetch Podman version and installer
FetchPodman-->>WindowsWorkflow: return local installer path
WindowsWorkflow->>DownloadPodmanNightly: pass installer and provider
DownloadPodmanNightly->>WindowsHost: copy and install MSI
WindowsHost-->>DownloadPodmanNightly: verify Podman installation
DownloadPodmanNightly->>WindowsHost: configure provider
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/desktop-e2e-podman-windows-matrix.yaml:
- Line 79: Update the download-podman-nightly composite action to accept an
installer-path input and use the local MSI when download_url is empty, while
preserving the existing podman-download-url behavior. Add coverage for both
nightly and main installation paths, including the local-installer fallback.
In @.github/workflows/desktop-e2e-test-job-windows.yaml:
- Line 76: Update the Windows Podman setup workflow around the
fetch-latest-podman-version-windows step to pass its local_installer_path output
through the downloader, while preserving download_url handling for non-nightly
versions. Add or update the nightly/main-path test to verify the local installer
path is forwarded and used when download_url is empty.
In @.github/workflows/podman-desktop-e2e-kubernetes.yaml:
- Line 74: Update the Windows Podman setup around the fetch-podman step and
download-podman-nightly invocation to pass the action’s installer-path output
instead of download_url. Add a condition or validation for nightly/main runs so
the installer path is populated before download-podman-nightly executes.
In @.github/workflows/podman-desktop-e2e-nightly-windows-wsl.yaml:
- Line 75: Update the workflow’s Podman installation handoff so nightly/main
runs use the installer path produced by fetch-latest-podman-version-windows via
local_installer_path instead of the empty download_url; preserve the existing
URL path for non-nightly runs, and add coverage validating the nightly dispatch
passes the local installer to download-podman-nightly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 81fd1058-3a3f-4633-aa3f-880987572bf9
📒 Files selected for processing (8)
.github/workflows/desktop-e2e-podman-windows-matrix.yaml.github/workflows/desktop-e2e-test-job-windows.yaml.github/workflows/podman-desktop-e2e-kubernetes.yaml.github/workflows/podman-desktop-e2e-nightly-windows-hyperv.yaml.github/workflows/podman-desktop-e2e-nightly-windows-wsl.yaml.github/workflows/podman-desktop-e2e-remote-windows.yaml.github/workflows/podman-desktop-e2e-stress-ui-windows.yaml.github/workflows/prerelease-desktop-e2e-debug-job-windows.yaml
Signed-off-by: Daniel Villanueva <[email protected]>
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/podman-desktop-e2e-nightly-windows-hyperv.yaml (1)
80-82: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winUpdate the default Podman version to
nightly.In the
podman-desktop-e2e-nightly-windows-wsl.yamlworkflow, theversion_inputfallback was updated to'nightly'to properly test the nightly bits. It appears this update was missed in this Hyper-V equivalent workflow (it currently falls back to'latest'on line 84).Please consider updating it to
'nightly'for consistency and correct nightly testing behavior. You may also want to verify if theworkflow_dispatchinput descriptions at the top of the file need the same update as the WSL workflow.💻 Proposed fix
- name: Fetch latest Podman version id: fetch-podman uses: redhat-actions/podman-install/.github/actions/fetch-latest-podman-version-windows@60b05ab5b050c9f8ec8dff7e0377f8bf36c39207 with: - version_input: ${{ github.event.inputs.podman_version || 'latest' }} + version_input: ${{ github.event.inputs.podman_version || 'nightly' }} file_type: 'msi'🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/podman-desktop-e2e-nightly-windows-hyperv.yaml around lines 80 - 82, Update the Hyper-V workflow’s Podman version fallback associated with fetch-podman from latest to nightly, matching the WSL nightly workflow. Also align the workflow_dispatch input description or default with the nightly value where applicable.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/actions/download-podman-nightly/action.yml:
- Around line 111-114: Update the user-level Path handling in the Podman
installation step so an unset or null $currentUserPath is treated as empty
before calling .Contains(). Preserve the existing behavior of avoiding duplicate
$podmanPath entries and appending the path for accounts with an existing
user-level Path.
---
Outside diff comments:
In @.github/workflows/podman-desktop-e2e-nightly-windows-hyperv.yaml:
- Around line 80-82: Update the Hyper-V workflow’s Podman version fallback
associated with fetch-podman from latest to nightly, matching the WSL nightly
workflow. Also align the workflow_dispatch input description or default with the
nightly value where applicable.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 40902de9-fdb9-40fe-be2d-c0573689ba3f
📒 Files selected for processing (9)
.github/actions/download-podman-nightly/action.yml.github/workflows/desktop-e2e-podman-windows-matrix.yaml.github/workflows/desktop-e2e-test-job-windows.yaml.github/workflows/podman-desktop-e2e-kubernetes.yaml.github/workflows/podman-desktop-e2e-nightly-windows-hyperv.yaml.github/workflows/podman-desktop-e2e-nightly-windows-wsl.yaml.github/workflows/podman-desktop-e2e-remote-windows.yaml.github/workflows/podman-desktop-e2e-stress-ui-windows.yaml.github/workflows/prerelease-desktop-e2e-debug-job-windows.yaml
Signed-off-by: Daniel Villanueva <[email protected]>
odockal
requested changes
Jul 15, 2026
| name: ${{ matrix.windows-version }} - ${{ matrix.rootful == '0' && 'rootless' || 'rootful' }} ${{ matrix.user-networking == '1' && '- user mode networking enabled' || '' }} | ||
| timeout-minutes: 180 | ||
| runs-on: ubuntu-latest | ||
| permissions: |
| name: ${{ matrix.windows-version }} - Debug | ||
| timeout-minutes: 180 | ||
| runs-on: ubuntu-latest | ||
| permissions: |
| name: ${{ matrix.windows-version }} - ${{ matrix.windows-featurepack }} | ||
| timeout-minutes: 90 | ||
| runs-on: ubuntu-latest | ||
| permissions: |
| name: ${{ matrix.windows-version }} - Debug | ||
| timeout-minutes: 180 | ||
| runs-on: ubuntu-latest | ||
| permissions: |
| description: 'The URL to download the Podman build from.' | ||
| required: false | ||
| default: '' | ||
| podman-local-installer: |
Contributor
There was a problem hiding this comment.
why cannot we just pass an url to the nightly so that the action/image can pull the installer and use it?
danivilla9
marked this pull request as draft
July 16, 2026 10:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates Windows E2E workflows to use the new
fetch-latest-podman-version-windowsaction from redhat-actions/podman-install#24 (pinned to60b05ab), which can fetch Podman from GitHub Actions nightly artifacts in addition to release URLs.Because nightly builds have no public download URL, this PR also extends
download-podman-nightlyto accept a local MSI path: whenlocal_installer_pathis set, the action SCPs the installer to the Windows VM and installs it there, then configures the Podman provider as before. All affected Windows workflows now forward bothdownload_urlandlocal_installer_path, and grantactions: readso nightly artifacts can be fetched. The nightly WSL workflow defaults topodman_version: nightly.Test plan
podman_version: latest(release URL path)podman_version: nightly(local MSI path)podman-desktop-e2e-nightly-windows-wslscheduled/dispatch run uses nightly by default