Skip to content

Add Alt+Shift layout switch, layout switch toast toggle#173

Merged
pzauner merged 1 commit into
palsoftware:mainfrom
rkarabut:add-alt-shift-layout-switch
May 6, 2026
Merged

Add Alt+Shift layout switch, layout switch toast toggle#173
pzauner merged 1 commit into
palsoftware:mainfrom
rkarabut:add-alt-shift-layout-switch

Conversation

@rkarabut

@rkarabut rkarabut commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

Adds the option to use Alt+Shift keyboard shortcut (in addition to Ctrl-Space) for cycling through keyboard layouts, along with an option to disable toast notifications on layout switch (as they tend to cover input at the bottom of the screen, especially with status bar off). Alt+Shift is more ergonomic than Ctrl-Space for Titan 1/2/Slim, and used to be my preferred option with other keyboards allowing physical key layout switching.

Tested and working on Unihertz Titan 2.

I added the options to the Customization page, please tell me if there is a better place for them.

@rkarabut

Copy link
Copy Markdown
Contributor Author

Pulled signing skip fixes from #157

@pzauner

pzauner commented May 6, 2026

Copy link
Copy Markdown
Collaborator

your "signing skip fixes from #157" were bad practice.

a852de4

@pzauner pzauner force-pushed the add-alt-shift-layout-switch branch from 6221273 to 685c782 Compare May 6, 2026 15:32
@pzauner

pzauner commented May 6, 2026

Copy link
Copy Markdown
Collaborator

I dropped the signing-skip changes from this PR. They were out of scope and not equivalent to the implementation already on main, especially around stable release validation.

I rebuilt the PR on top of current main as a focused Alt+Shift layout-switch change. The new settings now live in KeyboardLayoutSettingsScreen, alongside the existing layout/profile controls, instead of the generic customization screen. I also kept the toast toggle wired into the existing Ctrl+Space subtype switch path.

I added targeted tests for the new SettingsManager preferences, backup/restore schema coverage, and the IME Alt+Shift shortcut behavior to make sure the shortcut is consumed and modifier state is cleaned up.

@pzauner pzauner merged commit 016c4ff into palsoftware:main May 6, 2026
1 check passed
@rkarabut

rkarabut commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

Thanks, should've clarified it was to see if CI passes and to be reverted

your "signing skip fixes from #157" were bad practice.

a852de4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants