Add Alt+Shift layout switch, layout switch toast toggle#173
Merged
Conversation
Contributor
Author
|
Pulled signing skip fixes from #157 |
Collaborator
Co-authored-by: Patrick Zauner <[email protected]>
6221273 to
685c782
Compare
Collaborator
|
I dropped the signing-skip changes from this PR. They were out of scope and not equivalent to the implementation already on I rebuilt the PR on top of current I added targeted tests for the new SettingsManager preferences, backup/restore schema coverage, and the IME Alt+Shift shortcut behavior to make sure the shortcut is consumed and modifier state is cleaned up. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the option to use Alt+Shift keyboard shortcut (in addition to Ctrl-Space) for cycling through keyboard layouts, along with an option to disable toast notifications on layout switch (as they tend to cover input at the bottom of the screen, especially with status bar off). Alt+Shift is more ergonomic than Ctrl-Space for Titan 1/2/Slim, and used to be my preferred option with other keyboards allowing physical key layout switching.
Tested and working on Unihertz Titan 2.
I added the options to the Customization page, please tell me if there is a better place for them.