Skip to content

Scanvi model - #1104

Open
dorien-er wants to merge 24 commits into
mainfrom
scanvi-model
Open

Scanvi model#1104
dorien-er wants to merge 24 commits into
mainfrom
scanvi-model

Conversation

@dorien-er

@dorien-er dorien-er commented Nov 27, 2025

Copy link
Copy Markdown
Contributor

Changelog

  • Create a separate workflow to generate a scANVI reference model
  • Update scANVI annotation workflow to accept either a reference dataset or a pre-trained reference model

Issue ticket number and link

Closes #xxxx (Replace xxxx with the GitHub issue number)

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributor's guide

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI tests succeed!

Comment thread src/workflows/annotation/scanvi_scarches/config.vsh.yaml Outdated
Comment thread src/workflows/annotation/scanvi_scarches/main.nf Outdated
Comment thread src/workflows/annotation/scanvi_scarches/main.nf Outdated
Comment thread src/workflows/annotation/scanvi_scarches/main.nf Outdated
reference_obs_target: "cell_type",
reference_var_gene_names: "ensemblid",
max_epochs: 10,
obsm_embedding: "X_pca"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change intentional?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new workflow was added (embedding_model/scanvi_model). Could this workflow be used as a subworkflow in this one in case a reference model is not provided? Or is it not applicable?

Comment thread src/workflows/embedding_model/scanvi_model/config.vsh.yaml Outdated
Comment thread src/workflows/embedding_model/scanvi_model/main.nf Outdated
Comment thread src/workflows/test_workflows/embedding_model/scanvi_model/config.vsh.yaml Outdated
dorien-er and others added 23 commits February 27, 2026 16:14
…1106)

* CI: Use GITHUB_TOKEN when building containers with github resources

* Use mounts

* Add secret during build

* Undo some changes

* Remove a docker_run_args config value

* Remove some more docker_run_args
* Bump anndata and mudata [ci force]

* Fix multi_star

* Allow install as root for some python packages

* Fix leftover merge conflict

* Add CHANGELOG entry

* freebayes: use debian instead of ubuntu

* Remove cellbender and update from_seurat_to_h5mu

* Fix some builds [ci force]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants