Skip to content

8385815: [CRaC] Fix aarch64 failing testcases#321

Draft
jankratochvil wants to merge 6 commits into
openjdk:cracfrom
jankratochvil:8385815
Draft

8385815: [CRaC] Fix aarch64 failing testcases#321
jankratochvil wants to merge 6 commits into
openjdk:cracfrom
jankratochvil:8385815

Conversation

@jankratochvil

@jankratochvil jankratochvil commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

test/jdk/jdk/crac/CPUFeatures/SimpleCPUFeaturesTest.java
test/jdk/jdk/crac/engine/CheckCPUFeaturesTest.java

It needs some updates for the new CPU Features support.



Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8385815: [CRaC] Fix aarch64 failing testcases (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/321/head:pull/321
$ git checkout pull/321

Update a local copy of the PR:
$ git checkout pull/321
$ git pull https://git.openjdk.org/crac.git pull/321/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 321

View PR using the GUI difftool:
$ git pr show -t 321

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/crac/pull/321.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jun 2, 2026

Copy link
Copy Markdown

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into crac will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jun 2, 2026

Copy link
Copy Markdown

@jankratochvil This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk Bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 2, 2026
@mlbridge

mlbridge Bot commented Jun 2, 2026

Copy link
Copy Markdown

Webrevs

@jankratochvil

Copy link
Copy Markdown
Contributor Author

The failed CI is a false positive:

Comment thread src/hotspot/cpu/aarch64/vm_version_aarch64.cpp Outdated
@TimPushkin TimPushkin changed the title 8385815: CRaC: Fix aarch64 failing testcases 8385815: [CRaC] Fix aarch64 failing testcases Jun 3, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 8, 2026
@jankratochvil

Copy link
Copy Markdown
Contributor Author

With upstream CRIU it somehow does not work now:

+ bin/java -XX:CRaCCheckpointTo=cr -XX:+ShowCPUFeatures -XX:CRaCEngine=criuengine -XX:CPUFeatures=0x21461805ddfbf7,0xfcc0000000000000 CPUFeaturesAWS
This machine's CPU features are: -XX:CPUFeatures=0xe14e1b9dfdfbff,0xfcc0000000000000
CPU features being used are: -XX:CPUFeatures=0x21461805ddfbf7,0xfcc0000000000000
Original environment variable: GLIBC_TUNABLES=glibc.pthread.rseq=0
Re-exec of java with new environment variable: GLIBC_TUNABLES=glibc.pthread.rseq=0:glibc.cpu.hwcaps=,-ERMS,-AVX512F,-AVX512CD,-AVX512BW,-AVX512DQ,-AVX512VL
This machine's CPU features are: -XX:CPUFeatures=0xe14e1b9dfdfbff,0xfcc0000000000000
CPU features being used are: -XX:CPUFeatures=0x21461805ddfbf7,0xfcc0000000000000
CPUFeaturesCheck 0
CPUFeaturesCheck 1
+ set +e
+ bin/jcmd CPUFeaturesAWS JDK.checkpoint
CPUFeaturesCheck 2
CPUFeaturesCheck 3
CPUFeaturesCheck 4
CPUFeaturesCheck 5
CPUFeaturesCheck 6
CPUFeaturesCheck 7
Could not find any processes matching : 'CPUFeaturesAWS'
+ wait 2084
CPUFeaturesCheck 8
CPUFeaturesCheck 9
...
CPUFeaturesCheck 367
CPUFeaturesCheck 368
CPUFeaturesCheck 369
...

@openjdk openjdk Bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 8, 2026
@jankratochvil jankratochvil marked this pull request as draft June 8, 2026 19:37
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 8, 2026
/**/

#define DECLARE_CPU_FEATURE_FLAG(id, name) CPU_##id,
#define DECLARE_CPU_FEATURE_FLAG(id, name, bit) CPU_##id = (bit),

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to have two versions: with and without an explicit ID to minimize the difference with the mainline? Currently CPU-features is already the most frequently conflicting part when merging with the mainline...

@TimPushkin TimPushkin mentioned this pull request Jun 12, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants