feat: support the service hostname key#8
Merged
Conversation
This was referenced Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Accept the Compose service
hostnamekey. Previouslycompose2podrejected it(
service '<name>': unsupported key 'hostname'), which broke real CI composefiles that set a hostname (e.g.
keydb: hostname: keydb-test-server-0) andconnect to the service by that name.
The hostname is folded into
graph.hostnames(), so it becomes an--add-host <hostname>:127.0.0.1entry - resolvable to loopback in the pod'sshared network namespace, exactly like a network alias already is. No
per-container
--hostnameis emitted (pod members share the UTS namespace).Why
The rejected name is load-bearing: the application connects to the service at
that hostname, so silently dropping it would emit a script that fails at
connect time. Full rationale, alternatives, and non-goals live in the change
file - this body does not restate them:
planning/changes/2026-07-08.01-service-hostname.mdarchitecture/supported-subset.mdTests
just test-ci- 86 passed, 100% line coverage.just lint-ciclean. Coverageat all three layers:
validateacceptance (test_parsing.py), hostnamecollection (
test_graph.py, incl. empty-hostname guard), and end-to-endvalidate->emit_scriptrendering the--add-hostentry (test_emit.py).