feat: support the service container_name key#12
Merged
Conversation
Mirrors the existing hostname support: container_name is accepted in
validate() and folded into graph.hostnames(), so it becomes an
--add-host <name>:127.0.0.1 entry. The actual podman container is still
named {pod}-{service} internally; only name resolution is affected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accepts
container_name, resolved to loopback exactly like the already-shippedhostnamesupport (#8): folded intograph.hostnames()->--add-host <name>:127.0.0.1. The real podman container name stays{pod}-{service}(unchanged) — only DNS-style resolution is affected, per the reporting user's confirmation that the name is also used as a hostname.Independently reviewed: ready to merge, no findings.
Design/spec:
planning/changes/2026-07-08.03-container-name.md.architecture/supported-subset.mdupdated in this PR.Tests
just test-ci— 92 passed, 100% line coverage.just lint-ciclean.