Add some notes to include-install-build-tools#27537
Open
CraigMacomber wants to merge 4 commits into
Open
Conversation
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (11 lines, 1 files), I've queued these reviewers:
How this works
|
alexvy86
approved these changes
Jun 12, 2026
alexvy86
left a comment
alexvy86
left a comment
Contributor
There was a problem hiding this comment.
A couple of suggestions but looks good otherwise.
…to include-install-build-tools-notes
Co-authored-by: Alex Villarreal <[email protected]>
CraigMacomber
added a commit
that referenced
this pull request
Jun 12, 2026
## Description This code used to simply try and parse an empty string as JSON and give an unexpected end of JSON syntax error if there was some issue, like those caused by include-install-build-tools overwriting the pnpm version causing pnpm to try and install a different version which failed due to network isolation (Noted in #27537 and blocking #27509). Now it actually outputs the errors in such cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pipeline template is problematic, and introduces an additional way to depend on build tools which we could probably do without. This clarifies the issues with it a bit.
These issues turned up when trying (and failing) to update build-tools to pnpm 11 which caused hard to root cause problems for users of this pipeline with the default "repo" mode.
Reviewer Guidance
The review process is outlined on this wiki page.