Skip to content

Better error handling in assignTestPorts#27538

Merged
CraigMacomber merged 1 commit into
microsoft:mainfrom
CraigMacomber:test-ports
Jun 12, 2026
Merged

Better error handling in assignTestPorts#27538
CraigMacomber merged 1 commit into
microsoft:mainfrom
CraigMacomber:test-ports

Conversation

@CraigMacomber

Copy link
Copy Markdown
Contributor

Description

This code used to simply try and parse an empty string as JSON and give an unexpected end of JSON syntax error if there was some issue, like those caused by include-install-build-tools overwriting the pnpm version causing pnpm to try and install a different version which failed due to network isolation (Noted in #27537 and blocking #27509). Now it actually outputs the errors in such cases.

Reviewer Guidance

The review process is outlined on this wiki page.

Copilot AI review requested due to automatic review settings June 12, 2026 18:44
@github-actions

Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (41 lines, 1 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@alexvy86 alexvy86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CraigMacomber CraigMacomber merged commit 9719967 into microsoft:main Jun 12, 2026
25 checks passed
@CraigMacomber CraigMacomber deleted the test-ports branch June 12, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants