Skip to content

Add strict comparison check #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AltamashShaikh merged 1 commit into from
Jul 22, 2026
Merged

Add strict comparison check #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## Changelog

* 5.3.3 - 2026-07-27 - Added strict comparison check
* 5.3.2 - 2026-06-29 - Added code to improve the access check before sending an alert
* 5.3.1 - 2026-06-08 - Added restrict access check for MultiSites.getAll report for non superusers
* 5.3.0 - 2026-05-11 - Added alert description and helptexts
Expand Down
2 changes: 1 addition & 1 deletion CustomAlerts.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ public function deleteAlertsForLogin($userLogin)
$alerts = $this->getAllAlerts();

foreach ($alerts as $alert) {
if ($alert['login'] == $userLogin) {
if ((string) $alert['login'] === (string) $userLogin) {
$model->deleteAlert($alert['idalert']);
}
}
Expand Down
2 changes: 1 addition & 1 deletion Validator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ public function checkApiMethodAndMetric($idSite, $apiMethodUniqueId, $metric)
*/
public function checkUserHasPermissionForAlert($alert)
{
if (Piwik::getCurrentUserLogin() != $alert['login']) {
if ((string) Piwik::getCurrentUserLogin() !== (string) $alert['login']) {
throw new Exception(Piwik::translate('CustomAlerts_AccessException', $alert['idalert']));
}
}
Expand Down
2 changes: 1 addition & 1 deletion plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "CustomAlerts",
"description": "Create custom Alerts to be notified of important changes on your website or app! ",
"version": "5.3.2",
"version": "5.3.3",
"require": {
"matomo": ">=5.0.0-b1,<6.0.0-b1"
},
Expand Down
Loading