Skip to content

Add strict comparison check#268

Merged
AltamashShaikh merged 1 commit into
5.x-devfrom
strict-comparison
Jul 22, 2026
Merged

Add strict comparison check#268
AltamashShaikh merged 1 commit into
5.x-devfrom
strict-comparison

Conversation

@AltamashShaikh

Copy link
Copy Markdown
Contributor

Description

Add strict comparison check

Issue No

Steps to Replicate the Issue

Checklist

  • [✔] Tested locally or on demo2/demo3?
  • [NA] New test case added/updated?
  • [NA] Are all newly added texts included via translation?
  • [NA] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [✔] Version bumped?
  • [✔] I have understood, reviewed, and tested all AI outputs before use
  • [✔] All AI instructions respect security, IP, and privacy rules
  • [✔] Documentation updated?

@snake14 snake14 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@lachiebol lachiebol left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, besides the test concerns that Jacob mentioned

@AltamashShaikh
AltamashShaikh merged commit 18d003c into 5.x-dev Jul 22, 2026
9 checks passed
@AltamashShaikh
AltamashShaikh deleted the strict-comparison branch July 22, 2026 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants