Skip to content

file_scan: skip hardlinks in --fdupes instead of aborting (#389) #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martinus wants to merge 1 commit into
base: master
Choose a base branch
from
Open

file_scan: skip hardlinks in --fdupes instead of aborting (#389) #412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions file_scan.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1258,5 +1258,17 @@ void add_file_fdupes(char *path)
eprintf("statx on %s: %s\n", path, strerror(errno));
return;
}

/*
* Filerecs are keyed by inode. Two hardlinks in the same fdupes group
* would produce a duplicate key and abort in insert_filerec(). They
* already share storage, so deduping them is pointless anyway - skip
* any inode we've already listed.
*/
if (filerec_find(st.stx_ino)) {
vprintf("Skipping %s: hardlink to an already-listed file\n",
path);
return;
}
filerec_new(path, st.stx_ino, st.stx_size);
}