file_scan: skip hardlinks in --fdupes instead of aborting (#389) - #412
Open
martinus wants to merge 1 commit into
Open
file_scan: skip hardlinks in --fdupes instead of aborting (#389)#412martinus wants to merge 1 commit into
martinus wants to merge 1 commit into
Conversation
…#389) Filerecs are keyed by inode. Two hard links in the same --fdupes group produced the same key and tripped the "should never happen" abort in insert_filerec(), core-dumping the whole run. Hard links already share storage, so skip any inode already listed instead. The regular scan path has an equivalent guard; --fdupes lacked one. Fixes: markfasheh#389 Co-Authored-By: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
Filerecs are keyed by inode. Two hard links to the same inode in a single
--fdupesgroup produce the same key and trip the "should never happen" abort ininsert_filerec().What happens without the fix
duperemove --fdupescore-dumps the entire run when the input list contains two or more hard links to the same file.The fix
Hard links already share storage, so deduping them is pointless anyway — skip any inode already listed. The regular scan path already has an equivalent guard;
--fdupessimply lacked one.Fixes: #389