-
Notifications
You must be signed in to change notification settings - Fork 4
Feature: Lexxy support #718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5a0edf0
Bump the ruby group with 2 updates
dependabot[bot] 28b1582
Bump prettier from 3.8.4 to 3.9.4 in the js group
dependabot[bot] 28422b0
Churn: update dependencies
sfnelson 43dcefa
Refactor: min-block-size in place of min-height
sfnelson c8b6055
Provide a default CSS fallback when HotwireCombobox is not available
sfnelson b406199
Mark FormBuilder admin_ buttons as deprecated
sfnelson 9f8b553
Remove unused legacy helpers for content forms
sfnelson 7e96f8d
Define admin_direct_uploads_url
sfnelson 04a44d3
Bump ruby dependency to 4.0
sfnelson 15f65c1
Upgrade katalyst-govuk-formbuilder to 1.28.0
sfnelson d19e5b8
Add lexxy support for Koi admins
sfnelson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| :root { | ||
| /* Colors */ | ||
| --lexxy-color-ink: var(--color-dark); | ||
| --lexxy-color-ink-medium: var(--color-dark-glare); | ||
| --lexxy-color-ink-light: var(--color-mid); | ||
| --lexxy-color-ink-lighter: var(--color-tint); | ||
| --lexxy-color-ink-lightest: var(--color-tint); | ||
| --lexxy-color-ink-inverted: var(--color-light); | ||
|
|
||
| /* Typography */ | ||
| --lexxy-font-base: var(--font-base); | ||
| --lexxy-font-mono: var(--font-mono); | ||
| --lexxy-text-small: var(--size-step--1); | ||
| --lexxy-content-margin: var(--space-s); | ||
|
|
||
| /* Focus ring */ | ||
| --lexxy-focus-ring-color: var(--focus-color); | ||
| } | ||
|
|
||
| :where(lexxy-toolbar) { | ||
| border: none; | ||
| } | ||
|
|
||
| :where(lexxy-editor) { | ||
| --lexxy-editor-padding: var(--space-2xs); | ||
| --lexxy-editor-rows: 5lh; | ||
|
|
||
| @supports (min-block-size: attr(rows lh)) { | ||
| --lexxy-editor-rows: attr(rows lh, 5lh); | ||
| } | ||
|
|
||
| border: none; | ||
| margin-block-end: var(--flow-space, var(--space-2xs)); | ||
|
|
||
| [role="textbox"] { | ||
| border-radius: var(--input-radius); | ||
| border: var(--stroke-input); | ||
|
|
||
| &:focus-visible { | ||
| outline: var(--focus-outline); | ||
| outline-offset: 0; | ||
| box-shadow: var(--focus-shadow); | ||
| } | ||
|
|
||
| .govuk-rich-textarea--error &:not(:focus-visible) { | ||
| border-color: var(--govuk-error-color); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| .govuk-error-message:has(+ lexxy-editor) { | ||
| margin-block-end: unset; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
app/controllers/admin/active_storage/direct_uploads_controller.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| module Admin | ||
| module ActiveStorage | ||
| class DirectUploadsController < ::ActiveStorage::DirectUploadsController | ||
| include Koi::Controller | ||
| end | ||
| end | ||
| end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.