Fix Windows EBUSY flake in doctorFix integration test#115
Merged
jsilvanus merged 1 commit intoJun 24, 2026
Merged
Conversation
…tion test afterAll's rmSync of the temp repo dir can hit a transient lock from the git subprocesses spawned in beforeAll on Windows runners — same pattern already handled in profileFirstRun.test.ts. Cleanup is best-effort, not test-critical, so swallow the error instead of failing the suite. Co-Authored-By: Claude Sonnet 4.6 <[email protected]> Claude-Session: https://claude.ai/code/session_01XaRDTbabmfzyo6EXzB53LD
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #114's Windows CI job failed with:
in
tests/integration/doctorFix.integration.test.ts'safterAll. This is a transient Windows-only lock left behind by the git subprocesses spawned inbeforeAll(not a SQLite-handle leak — the globaltests/setup/defaultSession.tssetup already points the default DB session at an in-memory database for every test file).tests/integration/profileFirstRun.test.tsalready wraps its equivalentrmSyncin atry/catchfor the same reason — this PR applies the identical pattern here.rmSync(repoDir, ...)inafterAllwithtry/catch(cleanup is best-effort, not test-critical).Test plan
npx vitest run tests/integration/doctorFix.integration.test.tspasses locallyTargets
claude/remaining-track-plan-pnye8c, notmain— per instruction, left open for manual approval/merge rather than auto-merged.Generated by Claude Code