fix: raise lspDiagnostics test timeouts for Windows CI#116
Merged
Conversation
Pre-existing flake unrelated to the doctor --fix work: tests using withFixtureDb() create real temp dirs + SQLite files and were hitting Vitest's default 5000ms timeout under loaded Windows CI runners.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
jsilvanus
changed the base branch from
claude/remaining-track-plan-pnye8c
to
main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/lspDiagnostics.test.ts(flags a path above the debt threshold but not one below it):Error: Test timed out in 5000ms.git diff origin/main...HEAD -- tests/lspDiagnostics.test.tsthat this test file is untouched by PR Multi-profile embedding serving, FTS deprecation cleanup, doctor --fix #114's diff — unrelated, pre-existing flake, just newly surfaced now that PR Multi-profile embedding serving, FTS deprecation cleanup, doctor --fix #114's branch finally got a full Windows CI run (blocked earlier by the EBUSY issue fixed in Fix Windows EBUSY flake in doctorFix integration test #115).vitest.config.tshas notestTimeoutconfigured, so Vitest's default 5000ms applies. The 6 tests in this file that usewithFixtureDb()create a real temp dir + open a real SQLite file viaopenDatabaseAt(), which can be slow enough on a loaded Windows CI runner to blow past 5s.15000ms timeout to each of the 6it(...)calls that usewithFixtureDb(), scoped to just those tests rather than bumping the globaltestTimeout.Verification
npx vitest run tests/lspDiagnostics.test.ts— 7/7 tests passed locally.Retargeted to
main: PR #114 (the original feature branch this was opened against) has since merged, so this now targetsmaindirectly so it actually gets CI and lands the fix wheremaincurrently lacks it.Per the standing instruction to fix Windows-only CI issues in a separate branch/PR and leave them for approval — this should not be merged until reviewed.
Generated by Claude Code