feat(sql): schema-aware completion for db blocks via the LSP#34
Open
gandarfh wants to merge 1 commit into
Open
feat(sql): schema-aware completion for db blocks via the LSP#34gandarfh wants to merge 1 commit into
gandarfh wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 3 of SQL support: the language server now offers context-aware SQL
completion inside ```db-* blocks (tables/columns from the app's cached
introspection), so completion is shared (desktop today, TUI later) instead
of reimplemented per surface.
Sql.complete ~tables ~text ~offset(pure): after FROM/JOIN/INTO/UPDATE ->table names; after a
table.qualifier -> that table's columns; otherwisecolumns + tables; partial word matched case-insensitively; column detail
carries the data type. Lexical context via the CST (
last_keyword_before)so a half-typed tail still classifies.
Sql_schema_store.tables_for ~connection_id: reads theschema_cachetable (connection id = the
db-<conn>fence suffix), grouping rows intoSql.tables; degrades to[]on no-db / read error / cold cache.on_completion: outside a{{ref}}, a db-* block falls back to SQLcompletion.
No desktop change yet (it keeps its client-side completion); retiring
cm-db-schema-complete.tslands with a later release.