feat(sql): cross-language ref-vs-column type check#35
Draft
gandarfh wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #34 (Phase 3). Phase 5 of Slice 5.
Adds a cross-language type check for the DB block: when a SQL column is compared
against a
{{ref}}(WHERE col = {{req1.response.body.id}}), the LSP warns if thecolumn's type category and the ref's inferred shape type are genuinely
incompatible.
lib/sql_types.ml— type lattice (Number/String/Boolean/Json/Datetime/Unknown)normalising native SQL column types (PG/MySQL/SQLite) and inferred ref shapes.
Leniency by design: Unknown always passes, Datetime<->String compatible.
lib/analyze.ml—sql_ref_diagnostics: pairs each ref with a comparison-adjacentfieldcolumn via the SQL CST, warns on incompatible categories.diagnosticsgains?shapes ?sql_tables_for ?doc.bin/httui-lsp/httui_lsp.ml—publish_diagnosticsfeeds the schema_cache tablesand doc text through.
Diagnostics already flow to the desktop, so the squiggle surfaces without any
frontend wiring.
Do not merge before #34.