Codectx v0.2: deterministic repository context packets#4
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
greygoody
left a comment
There was a problem hiding this comment.
Blocking release-review finding on the current head:
The v0.2 compatibility surface is broader than the preserved legacy binary actually supports.
context_main.rsadvertises and forwardseventsandcheck.- The preserved
codectx-legacycommand enum implementsokbut does not implementeventsorcheck. - The wrapper checks for any
--helpbefore legacy dispatch, so commands such ascodectx ok --helpshow the new context-compiler help rather than the legacy subcommand help. - README currently cites
codectx eventsas a supported forwarding example.
Please make the compatibility contract truthful before merge:
- Dispatch recognized legacy commands before handling global help, so legacy subcommand help reaches
codectx-legacy. - Either map
checkexplicitly to legacyok, or stop advertisingcheck. - Remove
eventsfrom the public compatibility list and README unless the event command is actually promoted in this release. - Add CLI integration coverage for forwarded legacy help and the
check/okdecision. - Re-run the complete accepted proof on the resulting head.
The context-packet implementation itself reviewed coherently: packet authority boundaries, explicit missing-focus behavior, deterministic projections, external-claim handling, fixture coverage, and generated-state hygiene are all consistent. I am withholding merge only for the published compatibility mismatch above.
Public MVP
Promote Codectx from an early bounded-session foundation into a reproducible repository context compiler for humans and coding tools.
Implemented
external_claimwithunknownfreshness;codectx-legacyruntime and truthful v0.2 compatibility forwarding;Explicit v0.2 policies
.codectx/focus.tomlmay be absent;--focus PATHis an error at both CLI and core-builder boundaries;codectxforward tocodectx-legacywhen both binaries are installed;codectx checkmaps explicitly to legacyok;events, are not advertised;.codectx/handoffs/latest.jsonis the primary managed handoff, while--output PATHremains available for explicit integrations.Boundary
Codectx renders context. Runseal owns obligation meaning, evidence validity, resolution, and regression. This PR does not add closure evaluation, proof authority, orchestration, indexing, a daemon, or a database.
Accepted proof
GitHub Actions run #43 passed on accepted head
c2a51580a068aa087948fd11ca26ac10f5acf0e6:cargo fmt --all --check;cargo clippy --workspace --all-targets -- -D warnings;cargo test --workspace;cargo run -p codectx-cli --bin codectx -- --help;bash scripts/demo.sh.Independent local validation also passed
just check, built both binaries, verified root help excludesevents, and verified bothcodectx ok --helpandcodectx check --helpreach legacyokhelp.Reviewer journey
Repository decision
This is the single canonical public context-packet promotion. Duplicate draft PR #7 was closed after its useful presentation work was incorporated here.
Release decision
The blocking compatibility review was resolved on the accepted head. This PR is approved for merge. Tag the resulting public release commit as
v0.2.0after merge.