This repository was archived by the owner on Jul 29, 2022. It is now read-only.
php version >=7.0#39
Open
gorghoa wants to merge 1 commit into
Open
Conversation
Owner
Author
|
ref #38 |
Collaborator
|
LGTM |
vincentchalamon
approved these changes
Sep 25, 2020
Merged
Merged
vincentchalamon
suggested changes
Oct 7, 2020
vincentchalamon
left a comment
vincentchalamon
left a comment
Collaborator
There was a problem hiding this comment.
Need rebase + update code according to PHP7 optimizations (typehint, etc.)
Owner
Author
|
So, which php 7 lowest version shall we support? Regarding https://www.php.net/supported-versions.php:
I would personally be comfortable to require at least php 7.2 (eventually php 7.3 since php 7.2 will stop being supported within a month) |
Collaborator
Agree with 7.2 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set minimum php version to 7.0.
Builds on php 5 are failing and I don’t see the point to take time to maintain them.