Skip to content
This repository was archived by the owner on Jul 29, 2022. It is now read-only.

SF5 Compatibility#38

Merged
gorghoa merged 1 commit into
gorghoa:masterfrom
magarzon:master
Oct 7, 2020
Merged

SF5 Compatibility#38
gorghoa merged 1 commit into
gorghoa:masterfrom
magarzon:master

Conversation

@magarzon

Copy link
Copy Markdown
Contributor

Added SF5 compatibility

@gorghoa

gorghoa commented Sep 25, 2020

Copy link
Copy Markdown
Owner

Thanks @magarzon 👍

@vincentchalamon, builds failed on php5.5 and 5.6. I think we could allow them to fail, what do you think (see #39) ?

@magarzon, have you actually successfully run it with symfony 5 ?

@gorghoa gorghoa mentioned this pull request Sep 25, 2020
@gorghoa

gorghoa commented Sep 25, 2020

Copy link
Copy Markdown
Owner

Builds for #39 are not passing yet, but I am comfortable with your PR being merged now @magarzon.

Can you just allow php 5.5 and 5.6 to fail in .travis.yml ?

I’m open to divergent opinions though :-°

@magarzon

Copy link
Copy Markdown
Contributor Author

Thanks @magarzon

@vincentchalamon, builds failed on php5.5 and 5.6. I think we could allow them to fail, what do you think (see #39) ?

@magarzon, have you actually successfully run it with symfony 5 ?

Yes, I have tested in SF5 and it works.

@gorghoa gorghoa mentioned this pull request Oct 7, 2020
@gorghoa gorghoa merged commit f1b4a68 into gorghoa:master Oct 7, 2020
@gorghoa

gorghoa commented Oct 7, 2020

Copy link
Copy Markdown
Owner

thanks @magarzon 👍, v1.0.7 tagged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants