Skip to content

fix(update): correct inverted version comparison in update nagger #3347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szokeasaurusrex merged 3 commits into from
Jun 26, 2026
Merged

fix(update): correct inverted version comparison in update nagger #3347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
338bbf5
fix(update): correct inverted version comparison in update nagger
cursoragent Jun 26, 2026
2e3a3f6
test: remove unnecessary tests
szokeasaurusrex Jun 26, 2026
41840bd
meta: fix the changelog entry to include PR link
szokeasaurusrex Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

- (snapshots) Update `snapshots download` to use the new archive endpoint, triggering the archive build and polling until it is ready before downloading ([#3344](https://github.com/getsentry/sentry-cli/pull/3344))
- (snapshots) Show a clear "project was renamed" error instead of a cryptic JSON parse failure when uploading to a renamed project slug ([#3341](https://github.com/getsentry/sentry-cli/pull/3341))
- Fix update nagger never showing when a newer version is available ([#3347](https://github.com/getsentry/sentry-cli/issues/3347))

## 3.5.1

Expand Down
2 changes: 1 addition & 1 deletion src/utils/update.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ impl LastUpdateCheck {
if let Some(ref release_v) = self.last_fetched_version;
if let Some(ref check_v) = self.last_check_version;
then {
Version::parse(release_v.as_str()).unwrap() < Version::parse(VERSION).unwrap() &&
Version::parse(VERSION).unwrap() < Version::parse(release_v.as_str()).unwrap() &&
check_v.as_str() == VERSION
} else {
false
Expand Down
Loading