fix(update): correct inverted version comparison in update nagger#3347
Merged
szokeasaurusrex merged 3 commits intoJun 26, 2026
Conversation
Fixes getsentry#3290 The is_outdated() check compared the fetched release version against the running CLI version in the wrong direction, so the update nagger never prompted when a newer release was available. Add unit tests covering outdated, up-to-date, and dev-build scenarios.
Member
There was a problem hiding this comment.
lgtm in general, thanks for the contribution @syf2211
szokeasaurusrex
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the inverted semver comparison in
LastUpdateCheck::is_outdated()so the update nagger correctly prompts when a newer release is available.Motivation
Fixes #3290
When the running CLI version is older than the latest fetched release (e.g. running
3.3.0with fetched3.4.1), the update nagger never showed because the comparison checkedrelease < runninginstead ofrunning < release.Changes
is_outdated()toVERSION < release_vTests
cargo test utils::update::testsResult: 4 passed, 0 failed
Notes
check_v == VERSIONguard is unchanged — it prevents nagging from stale cache after the binary was upgraded since the last check.Version::parse(...).unwrap()panic behavior is unchanged legacy code (file already hasclippy::unwrap_usedexpect).