fix(lint): allow the v225 GOA snapshot#227
Merged
Merged
Conversation
The reranker-token linter forbids bare 'vN' tokens in publishable prose to stop the historical reranker shorthand creeping back in. Its GOA allowlist holds v160, v200, v210, v215, v220, v226, v227, v229 and v230, and skips v225. v225 is a real, loaded annotation_set (GOA 225, source_version '225' in the live database) and it is the start of the validation window of the sealed frame: the model is selected on v225 to v227 and measured on v227 to v230. Excluding it forces every document that states the frame honestly to hide half of it. PROTEA's rewritten results chapter tripped on exactly this line: 'validation window v225 to v227'. The two guard tests that pin the allowlist to nine exact tokens are updated to ten. v228 stays excluded, as its comment explains: it is a real release but outside the slice spec, and the spec is the authority. Verified: patched linter passes PROTEA's docs branch (was 1 offence) and still passes PROTEA develop; agent-farm's own 7 offences are pre-existing under both versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reranker-token linter's GOA allowlist skips v225, which is a real loaded
annotation_set(source_version = '225', verified in the live database) and the start of the validation window of the sealed frame: the model is selected on v225 to v227 and measured on v227 to v230.Excluding it forces any document that states the frame honestly to hide half of it. PROTEA's rewritten results chapter trips on exactly this line: "validation window v225 to v227".
The linter exists to catch the historical reranker
vNshorthand, not to forbid a real GOA snapshot. The two guard tests pinning the allowlist to nine exact tokens are updated to ten.v228stays excluded, as its own comment explains: a real release, outside the slice spec, and the spec is the authority.Verified, not assumed:
docs/sealed-headlinedocs/sealed-headlinedeveloppytest tests/test_lint_reranker_tokens.py: 37 passed.