Skip to content

Commit 3727426

Browse files
authored
fix(lint): allow the v225 GOA snapshot (#227)
The reranker-token linter forbids bare 'vN' tokens in publishable prose to stop the historical reranker shorthand creeping back in. Its GOA allowlist holds v160, v200, v210, v215, v220, v226, v227, v229 and v230, and skips v225. v225 is a real, loaded annotation_set (GOA 225, source_version '225' in the live database) and it is the start of the validation window of the sealed frame: the model is selected on v225 to v227 and measured on v227 to v230. Excluding it forces every document that states the frame honestly to hide half of it. PROTEA's rewritten results chapter tripped on exactly this line: 'validation window v225 to v227'. The two guard tests that pin the allowlist to nine exact tokens are updated to ten. v228 stays excluded, as its comment explains: it is a real release but outside the slice spec, and the spec is the authority. Verified: patched linter passes PROTEA's docs branch (was 1 offence) and still passes PROTEA develop; agent-farm's own 7 offences are pre-existing under both versions.
1 parent f7262c5 commit 3727426

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

scripts/lint-reranker-tokens.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@
1717
bare `vN` tokens (schema versions, build numbers, semver-without-dot)
1818
unrelated to reranker shorthands. Six token classes are allowed:
1919
20-
1. GOA snapshot identifiers: v160, v200, v210, v215, v220, v226, v227,
21-
v229, v230
20+
1. GOA snapshot identifiers: v160, v200, v210, v215, v220, v225, v226,
21+
v227, v229, v230
2222
2. Semver prefixes: any token immediately followed by ``.digit``
2323
(e.g. ``v0.3.0``, ``v2.1.13``). These are package/tool release
2424
strings, not reranker shorthands.
@@ -62,7 +62,7 @@
6262
# via the reusable workflow; do not duplicate elsewhere.
6363
GOA_ALLOWLIST: frozenset[str] = frozenset({
6464
"v160", "v200", "v210", "v215", "v220",
65-
"v226", "v227", "v229", "v230",
65+
"v225", "v226", "v227", "v229", "v230",
6666
})
6767

6868
# Method/scoring identifier that is NOT a reranker-version shorthand.

tests/test_lint_reranker_tokens.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,13 @@ def _load_module():
4141

4242

4343
class TestAllowlist:
44-
def test_allowlist_has_exactly_nine_tokens(self) -> None:
45-
assert len(linter.GOA_ALLOWLIST) == 9
44+
def test_allowlist_has_exactly_ten_tokens(self) -> None:
45+
assert len(linter.GOA_ALLOWLIST) == 10
4646

4747
def test_allowlist_exact_membership(self) -> None:
4848
expected = {
4949
"v160", "v200", "v210", "v215", "v220",
50-
"v226", "v227", "v229", "v230",
50+
"v225", "v226", "v227", "v229", "v230",
5151
}
5252
assert set(linter.GOA_ALLOWLIST) == expected
5353

0 commit comments

Comments
 (0)