feat(ui): add InfoCardRow component#1449
Conversation
…tack/openframe-oss-lib into feature/info-card-row
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a responsive ChangesInfoCardRow component
Chat mapper host export
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
openframe-frontend-core/src/stories/InfoCardRow.stories.tsx (1)
8-10: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueAvoid raw hex colors in styling.
As per coding guidelines, raw hex colors are not allowed. Even for a stand-in Storybook placeholder, consider using an ODS token utility class (like
bg-ods-border) instead of hardcoding raw hex values in inline styles.♻️ Proposed refactor
const companyLogo = ( - <div className="size-full" style={{ background: 'linear-gradient(135deg, `#5EFAF0`, `#F357BB`)' }} /> + <div className="size-full bg-ods-border" /> )🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@openframe-frontend-core/src/stories/InfoCardRow.stories.tsx` around lines 8 - 10, Replace the raw hex gradient in the companyLogo placeholder with an approved ODS token utility class such as bg-ods-border, removing the inline color style while preserving the existing full-size placeholder container.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@openframe-frontend-core/src/stories/InfoCardRow.stories.tsx`:
- Around line 8-10: Replace the raw hex gradient in the companyLogo placeholder
with an approved ODS token utility class such as bg-ods-border, removing the
inline color style while preserving the existing full-size placeholder
container.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 57fae13d-58c5-4f59-bb78-58ad56f246a6
📒 Files selected for processing (3)
openframe-frontend-core/src/components/ui/index.tsopenframe-frontend-core/src/components/ui/info-card-row.tsxopenframe-frontend-core/src/stories/InfoCardRow.stories.tsx
Summary
Adds a new
InfoCardRowUI component toopenframe-frontend-core— a responsive row layout for grouping info cards, with Storybook coverage.Changes
components/ui/info-card-row.tsx— newInfoCardRowcomponent with responsive layoutstories/InfoCardRow.stories.tsx— Storybook examplescomponents/ui/index.ts— export the new component from the UI barrelInfoCardRowfrom shrinking inside flex containersConsumer
Consumed by the hub
feat/herobranch (PR flamingo-stack/multi-platform-hub#793) inhero-ease-of-use-demo.tsx. This lib PR must merge + release before the hub build can resolve theInfoCardRowexport.🤖 Generated with Claude Code
Summary by CodeRabbit