feat(chat): shared skeleton/loading primitives for hero agent demos#1459
Merged
Conversation
…tack/openframe-oss-lib into feature/info-card-row
…es [preview:none] Lets short-message chat surfaces (e.g. hero-demo turns) render 1 body line per row instead of the default 3, so the skeleton matches real message height. Default 3 keeps existing consumers unchanged. Co-Authored-By: Claude Opus 4.8 <[email protected]>
…eview:none] fill=true top-anchors the rows and clips overflow so, with a generous messageCount, the skeleton covers the whole panel at any height instead of bottom-clustering. Default keeps the existing bottom-anchored scroll behavior. Co-Authored-By: Claude Opus 4.8 <[email protected]>
…n selectedAccent) [preview:none] Adds a cyan twin of the Tag 'selected' variant and plumbs a selectedAccent through QuickActionChip -> QuickActionChipButton, so an agent's chip group can show its own theme accent (fae pink / mingo cyan) for the active chip instead of the fixed pink / default yellow. Co-Authored-By: Claude Opus 4.8 <[email protected]>
…ll bar on mobile [preview:none]
previewMode surfaces (hero demo tabs) forced the phone full-screen header (large text-h2 title) below md. Add compact prop -> always render the h-14 desktop-style bar, skip ChatPanelHeaderMobile; EmbeddableChat passes compact={previewMode}.
Co-Authored-By: Claude Opus 4.8 <[email protected]>
…ia isMessagesLoading [preview:none] hasConversation now includes (previewMode && isMessagesLoading), so an embedded preview (no dialog manager to set isOpeningDialog) can render the message-list skeleton inside the real header + composer chrome instead of the new-user welcome. Lets hosts refresh only the thread. Co-Authored-By: Claude Opus 4.8 <[email protected]>
…ed chip skeleton) [preview:none] The row now draws the real QuickActionChipSkeleton chips in its own wrap/inline layout when loading, so consumers get a 1:1 chip skeleton instead of hand-rolling bars. Co-Authored-By: Claude Opus 4.8 <[email protected]>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
📝 WalkthroughWalkthroughWalkthroughThe chat UI gains configurable loading skeletons, loading quick-action placeholders, selected accent styling, and compact preview headers. A reusable responsive ChangesChat loading and preview states
Info card row component
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant EmbeddableChatInner
participant ChatPanelHeader
participant ChatMessageListSkeleton
EmbeddableChatInner->>EmbeddableChatInner: detect previewMode and isMessagesLoading
EmbeddableChatInner->>ChatPanelHeader: pass compact=true
ChatPanelHeader->>ChatPanelHeader: render compact desktop bar
EmbeddableChatInner->>ChatMessageListSkeleton: render conversation loading branch
Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Chat-component changes backing the multi-platform-hub homepage hero rebuild (hub #848). Everything here is a shared root primitive so the hub carries zero skeleton/loading duplication.
Changes (6 commits)
ChatMessageSkeletonbodyLinesprop — single-line skeleton rows for short scripted turns.ChatMessageListSkeletonfill mode — top-anchored rows + overflow clip so the skeleton covers the whole panel at any height instead of clustering at the bottom.Tag selectedCyan+QuickAction selectedAccent, so a selected quick-action chip uses the agent's theme accent (Fae pink / Mingo cyan) instead of the yellow primary.ChatPanelHeadercompact mode — embedded chat keeps the small header bar on mobile.EmbeddableChatin-chrome message skeleton —isMessagesLoadingrenders the message-list skeleton inside the real header + composer chrome (only the thread refreshes).ChatQuickActionRowloading/skeletonCount— wrap-aware shared chip skeleton (realQuickActionChipSkeleton, 1:1 geometry), so the hub's chip wall no longer hand-rolls placeholder bars.mapProcessedToUnifiedfrom the chat barrel for the hub's Mingo leg.Reviewer note
main, self-contained. This branch was cut fromfeature/info-card-row, so its InfoCardRow commits are included here too. feat(ui): add InfoCardRow component #1449 stays as a standalone PR of just that work; merge whichever lands first and the other rebases cleanly.🤖 Generated with Claude Code
Summary by CodeRabbit