Bump schema_version to 1.2#476
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
loichuder
force-pushed
the
up-graph-version
branch
2 times, most recently
from
July 1, 2026 06:44
6b60237 to
47bb9d8
Compare
loichuder
commented
Jul 1, 2026
Comment on lines
+15
to
+20
| """ | ||
| v1.1 does not have the __ewoks_serialize__ field. | ||
| It does not support the following link attributes: | ||
| - `cache_if_not_required` | ||
| - `required` when set explicitly to `False`, ignoring graph analysis | ||
| """ |
Member
Author
There was a problem hiding this comment.
I feel like this is not the greatest place to put the changes of the schema.
Should we create a CHANGELOG for the schema versions in the documentation?
Member
There was a problem hiding this comment.
Once the graph pydantic model is used we can probably do it in the pydantic model and perhaps generate the docs from that ... not sure.
Member
Author
There was a problem hiding this comment.
Could be good yes, we'll see. For now, I'll create a new page in the doc.
| save_graph( | ||
| graph, destination=tmp_path / f"{graph_name}.json", serializer=serializer | ||
| ) | ||
| assert (tmp_path / f"{graph_name}.json").exists() |
loichuder
force-pushed
the
up-graph-version
branch
2 times, most recently
from
July 1, 2026 06:51
1b556c9 to
1dd7a19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #456