Skip to content

Add new fields workflow_input_schema and workflow_output_schema to the spec#475

Merged
loichuder merged 3 commits into
mainfrom
add-input-schema-reloaded
Jul 1, 2026
Merged

Add new fields workflow_input_schema and workflow_output_schema to the spec#475
loichuder merged 3 commits into
mainfrom
add-input-schema-reloaded

Conversation

@loichuder

@loichuder loichuder commented Jun 30, 2026 •
edited by woutdenolf
Loading

Copy link
Copy Markdown
Member

For #437

Rework of #444 following #444 (comment)

@loichuder
loichuder force-pushed the add-input-schema-reloaded branch from 5a109ab to f292337 Compare June 30, 2026 13:52
@loichuder loichuder mentioned this pull request Jun 30, 2026
Closed
@loichuder
loichuder force-pushed the add-input-schema-reloaded branch from f292337 to 6ba7b7a Compare June 30, 2026 13:55
@codecov

codecov Bot commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.72727% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/ewokscore/graph/schema/parameter_schema.py 97.36% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@loichuder
loichuder requested a review from woutdenolf June 30, 2026 13:59
@woutdenolf

woutdenolf commented Jun 30, 2026

Copy link
Copy Markdown
Member

I would like the make a prod release of the current RC. Could you make a separate PR just for #456 please?

@loichuder

loichuder commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

I would like the make a prod release of the current RC. Could you make a separate PR just for #456 please?

I agree that it would better to make the release 5.0.0 first. PR done in #476

@loichuder
loichuder force-pushed the add-input-schema-reloaded branch from 6ba7b7a to 2f04489 Compare July 1, 2026 10:24
loichuder
loichuder commented Jul 1, 2026
View reviewed changes
Comment thread src/ewokscore/tests/examples/graphs/__init__.py
loichuder
loichuder commented Jul 1, 2026
View reviewed changes
Comment thread doc/howtoguides/change_schema.rst
woutdenolf
woutdenolf reviewed Jul 1, 2026
View reviewed changes
Comment thread src/ewokscore/graph/schema/parameter_schema.py
Comment thread src/ewokscore/graph/schema/parameter_schema.py
woutdenolf
woutdenolf approved these changes Jul 1, 2026
View reviewed changes

@woutdenolf woutdenolf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@loichuder
loichuder merged commit 73160b9 into main Jul 1, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woutdenolf woutdenolf woutdenolf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@loichuder @woutdenolf