chore: delete jellyfish-deploy-notification.yaml — no more callers (DEVEX-1653)#152
Merged
Merged
Conversation
Per-repo jellyfish-notify jobs were removed from every RT participant via the 22-PR sweep landed 2026-07-10 (DEVEX-1653 retire-rtv1). No workflow calls this shared reusable workflow anymore. Deleting it completes the Jellyfish removal. Manually verified across sample repos (webstore, returns-api, order-daemon, dms-daemon, manage): no residual jellyfish references in .github/workflows/. The gh code search index may show stale results for a bit but the actual file contents are clean. Rollback: revert this PR. Restoring individual per-repo jellyfish-notify jobs would require restoring them from each repo's git history too.
PR SummaryLow Risk Overview Nothing in this repo still references Jellyfish deploy notification after the broader RT-v1 retirement removed per-repo callers, so this shared workflow is dead code. Reviewed by Cursor Bugbot for commit 9b0d713. Bugbot is set up for automated code reviews on this repo. Configure here. |
pdodgen-revparts
added a commit
that referenced
this pull request
Jul 10, 2026
Surfaced by encodium/internal_api run 29114404344 (hotfix-SHOP-5216 workflow_dispatch → startup_failure). GH's workflow_dispatch runs startup validation over the entire reusable-workflow tree even for jobs gated `if:` off. A stale `uses: encodium/.github/.github/workflows/ jellyfish-deploy-notification.yaml@main` on a hotfix branch's deploy-eks.yaml — cut BEFORE the sweep merged today — resolves to this now-missing file, and startup validation fails before any job runs. Any long-lived branch across the org has the same footgun. This restores the workflow as a NO-OP stub: same input/secret signature as the deleted original so callers resolve cleanly, but the job body does nothing except log a deprecation ::notice::. No API call, no side effects. Long-lived branches with stale references stop hitting startup_failure immediately. As they merge/rebase, they naturally pick up the sweep from #152. Once branches have cycled (~1 month of active churn), we can delete this stub for real. The stub is a bandage, not a rollback of the retirement. All 22 participant sweep PRs stay merged; per-repo `jellyfish-notify` jobs stay gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to the 22-PR RT-v1 retirement sweep (all merged 2026-07-10). Per-repo jellyfish-notify jobs are gone from every RT participant, so this shared workflow has no callers.
Manually verified across a sample (webstore, returns-api, order-daemon, dms-daemon, manage) that no
.github/workflows/files reference jellyfish. gh's code search index may be briefly stale.Rollback: revert. Restoring the shared workflow alone doesn't restore behavior — callers were removed per-repo too.