Skip to content

fix(rt-v1): restore jellyfish-deploy-notification as no-op stub#153

Merged
pdodgen-revparts merged 1 commit into
mainfrom
devex-1653-jellyfish-stub
Jul 10, 2026
Merged

fix(rt-v1): restore jellyfish-deploy-notification as no-op stub#153
pdodgen-revparts merged 1 commit into
mainfrom
devex-1653-jellyfish-stub

Conversation

@pdodgen-revparts

Copy link
Copy Markdown
Contributor

Symptom

encodium/internal_api run 29114404344 — hotfix-SHOP-5216 workflow_dispatchstartup_failure.

Root cause: hotfix-SHOP-5216 was cut from main BEFORE today's sweep merged. Its deploy-eks.yaml (line 27) still has uses: encodium/.github/.github/workflows/jellyfish-deploy-notification.yaml@main. GH runs startup validation over the entire reusable-workflow tree even for jobs that would be if:-gated off. Since I deleted the shared workflow in #152 (a3b0afc), tree resolution fails before any job runs.

Every long-lived branch across the org that predates the sweep (feature branches, hotfix-*, dependabot PRs, in-flight work) has the same footgun.

Fix (this PR)

Restore jellyfish-deploy-notification.yaml as a no-op stub:

  • Same workflow_call input + secret signature as the deleted original → callers resolve cleanly
  • Job body does nothing except log a deprecation ::notice:: pointing at the retirement history
  • No API call to Jellyfish. No side effects. Never fails.

Long-lived branches stop hitting startup_failure immediately.

Not this PR — the retirement itself stands

Delete-for-real timeline

Once org-wide branch churn has cycled through (rough guideline: ~1 month), delete this stub in a follow-up. Anything actively worked on will have naturally rebased/merged and dropped the stale reference.

Surfaced by encodium/internal_api run 29114404344 (hotfix-SHOP-5216
workflow_dispatch → startup_failure). GH's workflow_dispatch runs
startup validation over the entire reusable-workflow tree even for
jobs gated `if:` off. A stale `uses: encodium/.github/.github/workflows/
jellyfish-deploy-notification.yaml@main` on a hotfix branch's
deploy-eks.yaml — cut BEFORE the sweep merged today — resolves to
this now-missing file, and startup validation fails before any job
runs. Any long-lived branch across the org has the same footgun.

This restores the workflow as a NO-OP stub: same input/secret
signature as the deleted original so callers resolve cleanly, but
the job body does nothing except log a deprecation ::notice::.
No API call, no side effects.

Long-lived branches with stale references stop hitting startup_failure
immediately. As they merge/rebase, they naturally pick up the sweep
from #152. Once branches have cycled (~1 month of active churn), we
can delete this stub for real.

The stub is a bandage, not a rollback of the retirement. All 22
participant sweep PRs stay merged; per-repo `jellyfish-notify` jobs
stay gone.
@pdodgen-revparts
pdodgen-revparts marked this pull request as ready for review July 10, 2026 18:57
@pdodgen-revparts
pdodgen-revparts requested a review from a team as a code owner July 10, 2026 18:57
@cursor

cursor Bot commented Jul 10, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
CI-only change with no runtime, auth, or data impact; the stub intentionally does nothing beyond logging a notice.

Overview
Restores the shared reusable workflow jellyfish-deploy-notification.yaml that was removed in #152, but only as a no-op stub so older branches still resolve the workflow at startup.

The stub keeps the same workflow_call inputs (environment, image_tag) and jellyfish_api_token secret so existing uses: references on long-lived branches no longer cause workflow_dispatch startup_failure when GitHub validates the reusable-workflow tree. The single job only emits a deprecation ::notice—no Jellyfish API calls or other side effects.

Per-repo Jellyfish job removals from the org sweep are unchanged; this is a compatibility bridge until branch churn drops stale references (~1 month), after which the stub can be deleted again.

Reviewed by Cursor Bugbot for commit 50509d2. Bugbot is set up for automated code reviews on this repo. Configure here.

@pdodgen-revparts
pdodgen-revparts merged commit 95cf1ec into main Jul 10, 2026
2 checks passed
@pdodgen-revparts
pdodgen-revparts deleted the devex-1653-jellyfish-stub branch July 10, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant