Skip to content

test(loop): isolate installer gh dependency #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codeacme17 merged 1 commit into from
Jul 24, 2026
Merged

test(loop): isolate installer gh dependency #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions loops/issue-dev-loop/tests/install-trusted-control-plane.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,13 @@ test('installer atomically publishes a read-only trusted control plane', async (
const installer = path.join(loopRoot, 'scripts', 'install-trusted-control-plane.mjs')
const target = path.join(fixtureRoot, 'trusted-control-plane')
const canonicalTarget = path.join(await realpath(fixtureRoot), 'trusted-control-plane')
const executableRoot = path.join(fixtureRoot, 'bin')
const fixtureGh = path.join(executableRoot, 'gh')
await Promise.all([
mkdir(path.dirname(installer), { recursive: true }),
mkdir(path.join(loopRoot, 'triggers'), { recursive: true }),
mkdir(path.join(repositoryRoot, 'loops', '_shared', 'owner-channel'), { recursive: true }),
mkdir(executableRoot),
])
await Promise.all([
cp(installerSource, installer),
Expand All @@ -75,6 +78,7 @@ test('installer atomically publishes a read-only trusted control plane', async (
'{}\n',
'utf8',
),
writeFile(fixtureGh, '#!/bin/sh\nexit 0\n', { encoding: 'utf8', mode: 0o755 }),
])

await git(repositoryRoot, ['init', '--initial-branch=dev'])
Expand All @@ -94,6 +98,10 @@ test('installer atomically publishes a read-only trusted control plane', async (

const { stdout } = await execFileAsync(process.execPath, [installer, '--target', target], {
cwd: repositoryRoot,
env: {
...process.env,
PATH: `${executableRoot}${path.delimiter}${process.env.PATH ?? ''}`,
},
})

const result = JSON.parse(stdout)
Expand All @@ -111,4 +119,5 @@ test('installer atomically publishes a read-only trusted control plane', async (
)
assert.equal(manifest.bundleRoot, canonicalTarget)
assert.equal(manifest.sourceCommit, sourceCommit)
assert.equal(manifest.executables.gh, await realpath(fixtureGh))
})