Skip to content

test(loop): isolate installer gh dependency#110

Merged
codeacme17 merged 1 commit into
devfrom
codex/bootstrap-control-plane-installer-ci
Jul 24, 2026
Merged

test(loop): isolate installer gh dependency#110
codeacme17 merged 1 commit into
devfrom
codex/bootstrap-control-plane-installer-ci

Conversation

@codeacme17

Copy link
Copy Markdown
Owner

Summary

  • provide an executable fixture gh for the trusted-control-plane installer integration test
  • prepend the fixture directory only for the installer subprocess
  • assert the generated manifest binds the fixture executable

Review finding

Resolves accepted finding RVW-1-1-1 from Traviinam review #109 (review). PR #109 was merged at head e794f6a before this repair was committed.

Verification

  • env PATH=/usr/bin:/bin /Users/leyoonafr/.nvm/versions/node/v24.5.0/bin/node --test loops/issue-dev-loop/tests/install-trusted-control-plane.test.mjs
  • pnpm loop:issue-dev:test (87 tests passed)
  • pnpm verify

Risk

Low. This changes only the installer integration-test fixture and removes dependence on a host-installed gh binary.

Owner controls Ready, approval, and merge.

@Traviinam Traviinam left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PASS

Reviewed immutable diff 376f838..8edc975.

  • Standards: PASS.
  • Spec: PASS. The test creates an executable gh outside the fixture repository, prepends it only to the installer subprocess PATH, preserves access to real git, and asserts the manifest binds the fixture executable.
  • Verification: restricted PATH=/usr/bin:/bin reproduction passed; loop suite passed 87/87. Reported full pnpm verify also passed.
  • Prior finding: RVW-1-1-1 is resolved.
  • Residual risk: full pnpm verify was not independently rerun during this review; the change is test-only and has no product, public API, Web Audio, React, accessibility, or package-runtime surface.

Reviewed head: 8edc975

Cycle-result digest marker: unavailable because PR #110 is a pre-activation bootstrap follow-up with no durable issue-loop run/result.

@codeacme17
codeacme17 marked this pull request as ready for review July 24, 2026 12:26
@codeacme17
codeacme17 merged commit 9eea053 into dev Jul 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants