test(loop): isolate installer gh dependency#110
Merged
Conversation
Traviinam
reviewed
Jul 24, 2026
Traviinam
left a comment
There was a problem hiding this comment.
PASS
Reviewed immutable diff 376f838..8edc975.
- Standards: PASS.
- Spec: PASS. The test creates an executable gh outside the fixture repository, prepends it only to the installer subprocess PATH, preserves access to real git, and asserts the manifest binds the fixture executable.
- Verification: restricted PATH=/usr/bin:/bin reproduction passed; loop suite passed 87/87. Reported full pnpm verify also passed.
- Prior finding: RVW-1-1-1 is resolved.
- Residual risk: full pnpm verify was not independently rerun during this review; the change is test-only and has no product, public API, Web Audio, React, accessibility, or package-runtime surface.
Reviewed head: 8edc975
Cycle-result digest marker: unavailable because PR #110 is a pre-activation bootstrap follow-up with no durable issue-loop run/result.
codeacme17
marked this pull request as ready for review
July 24, 2026 12:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review finding
Resolves accepted finding RVW-1-1-1 from Traviinam review #109 (review). PR #109 was merged at head e794f6a before this repair was committed.
Verification
Risk
Low. This changes only the installer integration-test fixture and removes dependence on a host-installed gh binary.
Owner controls Ready, approval, and merge.