Change 1d to 1D/update unittest trigger - #1183
Conversation
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1183 +/- ##
=======================================
Coverage 91.14% 91.14%
=======================================
Files 91 91
Lines 5365 5365
Branches 681 681
=======================================
Hits 4890 4890
Misses 340 340
Partials 135 135
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Oh I didn't see this PR (tooo many GH emails). We can go with the ** if you all want. |
|
Why is #849 partial? |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b287974. Configure here.

Summary of Changes
updating 1d to 1D ahead of pandas deprecation
updating '*' to '**' to catch slash in branch name
Related GitHub Issue(s)
fixes #849
fixes #1182
Additional Context for Reviewers
no more deprecation warning for
dhereChecklist
uv run pytest) and documentation changes (uv run --directory docs jb build . --builder=custom --custom-builder=doctest)Note
Low Risk
Small compatibility and CI trigger tweaks with no auth, data, or behavioral logic changes beyond avoiding pandas deprecations.
Overview
Updates the unit-test workflow so push runs on all branch names, including those with slashes, by changing the branch filter from
'*'to'**'.In
TriangleBase, development-lag calculation now uses pandas’1Dday rounding instead of deprecated1d, and datetime mapping callsSeries.mapwithout the removedarg=keyword.Reviewed by Cursor Bugbot for commit 337982f. Bugbot is set up for automated code reviews on this repo. Configure here.