Skip to content

Change 1d to 1D/update unittest trigger - #1183

Open
henrydingliu wants to merge 6 commits into
mainfrom
pands_4_prep
Open

Change 1d to 1D/update unittest trigger#1183
henrydingliu wants to merge 6 commits into
mainfrom
pands_4_prep

Conversation

@henrydingliu

@henrydingliu henrydingliu commented Aug 3, 2026

Copy link
Copy Markdown
Member

Summary of Changes

updating 1d to 1D ahead of pandas deprecation
updating '*' to '**' to catch slash in branch name

Related GitHub Issue(s)

fixes #849
fixes #1182

Additional Context for Reviewers

no more deprecation warning for d here

Checklist

  • I passed tests locally for both code (uv run pytest) and documentation changes (uv run --directory docs jb build . --builder=custom --custom-builder=doctest)

Note

Low Risk
Small compatibility and CI trigger tweaks with no auth, data, or behavioral logic changes beyond avoiding pandas deprecations.

Overview
Updates the unit-test workflow so push runs on all branch names, including those with slashes, by changing the branch filter from '*' to '**'.

In TriangleBase, development-lag calculation now uses pandas’ 1D day rounding instead of deprecated 1d, and datetime mapping calls Series.map without the removed arg= keyword.

Reviewed by Cursor Bugbot for commit 337982f. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Pyright Type Completeness

View the full pyright --verifytypes output for this commit

Project (full chainladder package, at this PR's head): 15.0% of exported symbols fully typed (196 / 1305)

Known Ambiguous Unknown Total
Project (head) 196 110 999 1305

Other symbols referenced but not exported by chainladder: 13

Known Ambiguous Unknown Total
Other (head) 3 1 9 13

Symbols without documentation:

  • Functions without docstring: 315
  • Functions without default param: 0
  • Classes without docstring: 10

Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected.

@henrydingliu henrydingliu changed the title Change 1d to 1D due to pandas deprecation Change 1d to 1D/update unittest trigger Aug 3, 2026
@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.14%. Comparing base (8461cfb) to head (337982f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1183   +/-   ##
=======================================
  Coverage   91.14%   91.14%           
=======================================
  Files          91       91           
  Lines        5365     5365           
  Branches      681      681           
=======================================
  Hits         4890     4890           
  Misses        340      340           
  Partials      135      135           
Flag Coverage Δ
unittests 91.14% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@henrydingliu
henrydingliu marked this pull request as ready for review August 3, 2026 05:46

@priyam0k priyam0k left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me!

@kennethshsu

Copy link
Copy Markdown
Member

Oh I didn't see this PR (tooo many GH emails). We can go with the ** if you all want.

@kennethshsu

Copy link
Copy Markdown
Member

Why is #849 partial?

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b287974. Configure here.

Comment thread chainladder/core/base.py Outdated
@henrydingliu

Copy link
Copy Markdown
Member Author

Why is #849 partial?

added fix for other half of #849

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] unittest not triggered on branch names with slash New warnings from Pandas 3

3 participants