Streamlined the unit tests and addressed unit tests bug - #1191
Streamlined the unit tests and addressed unit tests bug#1191kennethshsu wants to merge 2 commits into
Conversation
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1191 +/- ##
=======================================
Coverage 91.14% 91.14%
=======================================
Files 91 91
Lines 5365 5365
Branches 681 681
=======================================
Hits 4890 4890
Misses 340 340
Partials 135 135
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
i'm a little worried about this approach. this workflow file is shared by all forks. so changing it to run on main only also make it harder for everyone to run tests on their forks. and since most contributors are using issue specific branches from their fork to raise PRs, this means basically no tests anywhere unless there's a PR into main. gene very recently addressed some of the 'test flood' issue by introducing concurrency guards. so we should already be in better shape. i implore you to reconsider this drastic reduction in testing frequency. |
missed this part, can we switch main to ** instead so ci still runs on feature branch pushes? |
|
I guess I was thinking about conserving the CI resources here especially with that huge duplicator matrix when both
This is not true? On line 9, CIs run when there's a PR open, even on PRs into branches that's not I think this might help:
By the way, I am not married to |
|
yes, what we are saying is that committing to |
|
agreed with henry. let's go with **! |
|
K let me close this we can go with #1183 |
Summary of Changes
Fixes 1182, previously, we used "*" only to catch the branch name, which can be escaped by "/", using "**" will fix that.
This fix goes one step further, as we are all familiar, there are WAAY too many tests that run on each PR. This PR will update that to run on every PR and push to main only, it will not rerun main multiple times.
Related GitHub Issue(s)
Closes #1182
Additional Context for Reviewers
Checklist
uv run pytest) and documentation changes (uv run --directory docs jb build . --builder=custom --custom-builder=doctest)Note
Low Risk
Only GitHub Actions trigger configuration changed; no application or test logic was modified.
Overview
CI trigger change in
pytest.yml:pushno longer uses the'*'branch filter (which could miss branches with/in the name). It now runs unit tests only on pushes tomain, whilepull_requeststill runs the full matrix on every PR.This cuts redundant workflow runs on feature branches and avoids duplicate runs when
mainis updated, without changing what runs on PRs.Reviewed by Cursor Bugbot for commit cc2051f. Bugbot is set up for automated code reviews on this repo. Configure here.