Skip to content

Fix SetGlyph() can remove the old and apply now glyph effect #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kissingers wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −0
Open

Fix SetGlyph() can remove the old and apply now glyph effect #392

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e5c6d6
Remove the old and apply now glyph effect
kissingers Jul 15, 2026
cb6e377
Merge branch 'master' into master
iThorgrim Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/LuaEngine/methods/PlayerMethods.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3561,9 +3561,20 @@ namespace LuaPlayer
uint32 glyphId = ALE::CHECKVAL<uint32>(L, 2);
uint32 slotIndex = ALE::CHECKVAL<uint32>(L, 3);

// Remove the effect of the old glyph if it exists
uint32 oldGlyphId = player->GetGlyph(slotIndex);
if (oldGlyphId)
if (GlyphPropertiesEntry const* oldEntry = sGlyphPropertiesStore.LookupEntry(oldGlyphId))
player->RemoveAurasDueToSpell(oldEntry->SpellId);

player->SetGlyph(slotIndex, glyphId, true);
player->SendTalentsInfoData(false); // Also handles GlyphData

// Apply the effect of the new glyph if it exists
if (glyphId)
if (GlyphPropertiesEntry const* glyphEntry = sGlyphPropertiesStore.LookupEntry(glyphId))
player->CastSpell(player, glyphEntry->SpellId, TriggerCastFlags(TRIGGERED_FULL_MASK & ~(TRIGGERED_IGNORE_SHAPESHIFT | TRIGGERED_IGNORE_CASTER_AURASTATE)));

return 0;
}

Expand Down
Loading