Fix SetGlyph() can remove the old and apply now glyph effect

[kissingers]

The original SetGlyph didn't remove old glyph effects and apply new ones. I've fixed it based on the logic in
void Player::ActivateSpec(uint8 spec)
If there is more good way, please improve it.

Summary by CodeRabbit

• Bug Fixes
  • Replacing a glyph now removes any effects granted by the previously equipped glyph in that slot.
  • Newly equipped glyph effects are applied immediately after the replacement.
  • Glyph and talent UI/state continue to refresh correctly when glyphs change.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 80f69cda-5403-4a07-9bf4-73764cb4a876

📥 Commits

Reviewing files that changed from the base of the PR and between 1e5c6d6 and cb6e377.

📒 Files selected for processing (1)

• src/LuaEngine/methods/PlayerMethods.h

🚧 Files skipped from review as they are similar to previous changes (1)

• src/LuaEngine/methods/PlayerMethods.h

---

📝 Walkthrough

Walkthrough

SetGlyph now removes the previously equipped glyph’s aura before updating glyph data, then casts the newly equipped glyph’s spell with specified trigger flags.

Changes

Glyph lifecycle handling

Layer / File(s)	Summary
Glyph replacement and application src/LuaEngine/methods/PlayerMethods.h	SetGlyph removes the previous glyph aura, updates talent and glyph data, and applies the new glyph spell with specified trigger flags.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title matches the core fix in SetGlyph(): removing the old glyph effect and applying the new one.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[kissingers]

Without this fix, the old effect will not remove and need relogin or change 2 Talent twice than take effect.

[kissingers]

This is my manual fix not with any AI, if there is more good way, can direct modify it.