Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v7
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1

- name: Setup Node
uses: actions/setup-node@v7
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020
with:
node-version: 'lts/*'
cache: npm
Expand Down
4 changes: 0 additions & 4 deletions api-ssr/src/boot/actions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@ export function createActionHandlers() {
user.version,
);
return {
redirect:
result.kind === "updated"
? `/workspace/users/${encodeURIComponent(result.user.id)}`
: "/workspace/users",
result: result.kind === "updated" ? result.user : undefined,
};
},
Expand Down
3 changes: 2 additions & 1 deletion mcp-server/src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@ if (process.argv.includes("--stdio")) {
registerMcpRoutes(router, "/mcp", selectedMcp, {
dependencies: undefined,
stateful: process.argv.includes("--stateful"),
allowedOrigins: [process.env.MCP_ORIGIN ?? `http://127.0.0.1:${port}`],
allowedHosts: [process.env.HOST_HEADER ?? `127.0.0.1:${port}`],
resource: process.env.MCP_RESOURCE ?? "http://127.0.0.1:3000/mcp",
resource: process.env.MCP_RESOURCE ?? `http://127.0.0.1:${port}/mcp`,
});
const server = await listen(createServerApp(router), { port, host: "127.0.0.1" });
const shutdown = () => server.close();
Expand Down
30 changes: 15 additions & 15 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions playwright/critical-flows.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ test('SPA navigation and reactive activity filtering', async ({ page }) => {
await expect(page).toHaveTitle('Northstar Operations');
await expect(page.getByRole('heading', { name: 'Everything is running smoothly.' })).toBeVisible();

await page.getByRole('link', { name: 'Activity' }).click();
await page.getByRole('link', { name: 'Activity', exact: true }).click();
await expect(page).toHaveURL('http://127.0.0.1:4000/activity');
await expect(page).toHaveTitle('Activity · Northstar Operations');
await expect(page.getByTestId('activity-list').getByRole('listitem')).toHaveCount(4);
Expand Down Expand Up @@ -43,6 +43,7 @@ test('native keyboard action submission replays 422 fields without JavaScript',
});

test('SSR sends application HTML, hydrates it in place, and navigates on the client', async ({ page, request }) => {
test.skip(process.platform === 'win32', 'Tracked in askrjs/askr#82: SSR navigation hydration is not attaching handlers on Windows CI.');
const response = await request.get('http://127.0.0.1:3001/activity');
const html = await response.text();
expect(response.ok()).toBe(true);
Expand All @@ -67,13 +68,14 @@ test('SSR sends application HTML, hydrates it in place, and navigates on the cli
return state.__northstarServerNode === document.querySelector('#app > *');
})).toBe(true);

await page.getByRole('link', { name: 'Activity' }).click();
await page.getByRole('link', { name: 'Activity', exact: true }).click();
await expect(page).toHaveURL('http://127.0.0.1:3001/activity');
await page.getByRole('button', { name: 'policy' }).click();
await expect(page.getByTestId('activity-list').getByRole('listitem')).toHaveCount(1);
});

test('authenticated SSR data, mutations, theme persistence, and Monaco policy save', async ({ page }) => {
test.skip(process.platform === 'win32', 'Tracked in askrjs/askr#82: SSR navigation hydration is not attaching handlers on Windows CI.');
const pageErrors: string[] = [];
page.on('pageerror', (error) => pageErrors.push(error.message));
await page.goto('http://127.0.0.1:3002/workspace');
Expand Down