fix: align examples with published contracts - #2
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the examples repo to match the currently published Askr/server/themes/UI contracts and dependencies, while keeping existing workflow action pinning changes intact and tightening a couple of example behaviors.
Changes:
- Refreshes resolved package versions in
package-lock.jsonfor the published@askrjs/*releases. - Updates example code/contracts: adjusts an SSR action handler payload and adds MCP origin allowlisting.
- Stabilizes Playwright navigation by requiring an exact “Activity” link match; pins GitHub Actions to SHAs.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| playwright/critical-flows.spec.ts | Makes “Activity” link selection unambiguous via exact: true. |
| package-lock.json | Updates resolved @askrjs/* package versions to newer published artifacts. |
| mcp-server/src/main.ts | Adds allowedOrigins for MCP routes (with a noted default resource port mismatch). |
| api-ssr/src/boot/actions.ts | Aligns action handler response shape by removing conditional redirect on update. |
| .github/workflows/ci.yml | Pins actions/checkout and actions/setup-node to specific commit SHAs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1
Validation