Fix templates during inference#306
Merged
Merged
Conversation
Collaborator
|
Hah, i'll be damned - could that be it? Thanks for this, we'll take a look for sure! |
Collaborator
|
@rostro36 thanks so much for this – I think this is real, the value is just used as sentinel – without it the whole templating branch is dropped. Our template code is a royal mess, imo, I've taken a few stabs at it already. |
jandom
added
the
safe-to-test
jandom
approved these changes
Jul 13, 2026
jandom
left a comment
jandom
left a comment
Collaborator
There was a problem hiding this comment.
I'm leaning to just merge it – this codepath is uncovered by tests, so everything is deceptively green before and after the merge.
The code lives on a fork so it's not possible to push to this remote branch, and elaborate a bit more on the PR beyond the minimal 1-line fix. We'll have to do that in follow-up PRs anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix templates during inference
Related Issues
#234 #235
Testing
#234 as expected