refactor: tests for structure.template - #309
Merged
Merged
Conversation
lock in the behavior seen in #306
jandom
added
the
safe-to-test
jandom
added
safe-to-test
jandom
added
safe-to-test
jandom
commented
Jul 13, 2026
jandom
commented
Jul 13, 2026
jandom
added
safe-to-test
jnwei
approved these changes
Jul 14, 2026
jnwei
left a comment
jnwei
left a comment
Contributor
There was a problem hiding this comment.
Overall this is a great scientific test. I also like the framework that you made for test cases, expected error range. We can definitely reuse this framework when we add more scientific tests.
I have a few nits regarding variable naming, but otherwise, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lock in the behavior seen in #306
Changes
Related Issues
Testing
Other Notes