fix: ensure BodyPartReader.read() returns bytes instead of bytearray#12409
Closed
armorbreak001 wants to merge 1 commit intoaio-libs:masterfrom
Closed
fix: ensure BodyPartReader.read() returns bytes instead of bytearray#12409armorbreak001 wants to merge 1 commit intoaio-libs:masterfrom
armorbreak001 wants to merge 1 commit intoaio-libs:masterfrom
Conversation
The read() method's return type annotation promises bytes, but both the decoded and raw paths returned the internal bytearray buffer. This caused TypeError with json.dumps and other serializers that don't accept bytearray. Convert both return values to bytes() to match the documented API.
Member
|
The PR description clearly repeats the disputed details in the bug report, suggesting no person has actually looked at the issue.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BodyPartReader.read() documents its return type as
bytes, but both the decoded and raw code paths returned the internalbytearraybuffer unchanged. This causedTypeError: Object of type bytearray is not JSON serializablewhen piping multipart data into json.dumps, msgpack, or any other serializer with strict type requirements.Changes
decoded_data(decode=True path) tobytes()before returningdata(raw path) tobytes()before returningBoth are 2-line changes in
aiohttp/multipart.pythat make the return values match the documented API contract.Fixes #12404